[airbyte-ci]: new check on python certified connector to validate the…

…ir base image use

airbyte-ci/connectors/pipelines/README.md

@@ -381,6 +381,7 @@ This command runs the Python tests for a airbyte-ci poetry package.
 ## Changelog
 | Version | PR                                                         | Description                                                                                               |
 | ------- | ---------------------------------------------------------- | --------------------------------------------------------------------------------------------------------- |
+| 1.9.0   | [#30527](https://github.com/airbytehq/airbyte/pull/30527)  | Add a new check for python connectors to make sure certified connectors use our base image.                                                                            |
 | 1.8.0   | [#31369](https://github.com/airbytehq/airbyte/pull/31369)  | Remove metadata test commands                                                                             |
 | 1.7.2   | [#31343](https://github.com/airbytehq/airbyte/pull/31343)  | Bind Pytest integration tests to a dockerhost.                                                                  |
 | 1.7.1   | [#31332](https://github.com/airbytehq/airbyte/pull/31332)  | Disable Gradle step caching on source-postgres.                                                                  |

airbyte-ci/connectors/pipelines/pipelines/tests/common.py

@@ -283,3 +283,29 @@ async def _build_connector_acceptance_test(self, connector_under_test_image_tar:
             )
 
         return cat_container.with_unix_socket("/var/run/docker.sock", self.context.dagger_client.host().unix_socket("/var/run/docker.sock"))
+
+
+class CheckBaseImageIsUsed(Step):
+    title = "Check our base image is used"
+
+    async def _run(self, *args, **kwargs) -> StepResult:
+        is_certified = self.context.connector.metadata.get("supportLevel") == "certified"
+        if not is_certified:
+            self.skip("Connector is not certified, it does not require the use of our base image.")
+
+        is_using_base_image = self.context.connector.metadata.get("connectorBuildOptions", {}).get("baseImage") is not None
+        migration_hint = f"Please run 'airbyte-ci connectors --name={self.context.connector.technical_name} migrate-to-base-image {self.context.pull_request.number}' and commit the changes."
+        if not is_using_base_image:
+            return StepResult(
+                self,
+                StepStatus.FAILURE,
+                stdout=f"Connector is certified but does not use our base image. {migration_hint}",
+            )
+        has_dockerfile = "Dockerfile" in await (await self.context.get_connector_dir(include="Dockerfile")).entries()
+        if has_dockerfile:
+            return StepResult(
+                self,
+                StepStatus.FAILURE,
+                stdout=f"Connector is certified but is still using a Dockerfile. {migration_hint}",
+            )
+        return StepResult(self, StepStatus.SUCCESS, stdout="Connector is certified and uses our base image.")

airbyte-ci/connectors/pipelines/pipelines/tests/python_connectors.py

@@ -14,7 +14,7 @@
 from pipelines.builds.python_connectors import BuildConnectorImages
 from pipelines.consts import LOCAL_BUILD_PLATFORM
 from pipelines.contexts import ConnectorContext
-from pipelines.tests.common import AcceptanceTests
+from pipelines.tests.common import AcceptanceTests, CheckBaseImageIsUsed
 from pipelines.utils import export_container_to_tarball
 
 
@@ -226,6 +226,7 @@ async def run_all_tests(context: ConnectorContext) -> List[StepResult]:
         tasks = [
             task_group.soonify(IntegrationTests(context).run)(connector_container),
             task_group.soonify(AcceptanceTests(context).run)(connector_image_tar_file),
+            task_group.soonify(CheckBaseImageIsUsed(context).run)(),
         ]
 
     return step_results + [task.value for task in tasks]

airbyte-ci/connectors/pipelines/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"
 
 [tool.poetry]
 name = "pipelines"
-version = "1.8.0"
+version = "1.9.0"
 description = "Packaged maintained by the connector operations team to perform CI for connectors' pipelines"
 authors = ["Airbyte <contact@airbyte.io>"]
 

airbyte-integrations/connectors/source-file/metadata.yaml

@@ -29,3 +29,4 @@ data:
     ql: 400
   supportLevel: certified
 metadataSpecVersion: "1.0"
+# TO REVERT

airbyte-integrations/connectors/source-google-sheets/metadata.yaml

@@ -25,3 +25,4 @@ data:
     ql: 400
   supportLevel: certified
 metadataSpecVersion: "1.0"
+# TO REVERT