🚨🚨 Source Facebook Marketing: Add statuses filters (#32449)

Co-authored-by: Anatolii Yatsuk <tolikyatsuk@gmail.com>
airbytehq · Feb 20, 2024 · dd01ba3 · dd01ba3
1 parent e7ab4f5
commit dd01ba3
Show file tree

Hide file tree

Showing 31 changed files with 1,507 additions and 436 deletions.
diff --git a/airbyte-integrations/connectors/source-facebook-marketing/integration_tests/conftest.py b/airbyte-integrations/connectors/source-facebook-marketing/integration_tests/conftest.py
@@ -28,8 +28,41 @@ def config_with_wrong_account_fixture(config):
 
 
 @pytest.fixture(scope="session", name="config_with_include_deleted")
-def config_with_include_deleted_fixture(config):
-    new_config = {**config, "include_deleted": True}
+def config_with_include_deleted(config):
+    new_config = {
+        **config,
+        "campaign_statuses": [
+            "ACTIVE",
+            "ARCHIVED",
+            "DELETED",
+            "IN_PROCESS",
+            "PAUSED",
+            "WITH_ISSUES",
+        ],
+        "adset_statuses": [
+            "ACTIVE",
+            "ARCHIVED",
+            "CAMPAIGN_PAUSED",
+            "DELETED",
+            "IN_PROCESS",
+            "PAUSED",
+            "WITH_ISSUES",
+        ],
+        "ad_statuses": [
+            "ACTIVE",
+            "ADSET_PAUSED",
+            "ARCHIVED",
+            "CAMPAIGN_PAUSED",
+            "DELETED",
+            "DISAPPROVED",
+            "IN_PROCESS",
+            "PAUSED",
+            "PENDING_BILLING_INFO",
+            "PENDING_REVIEW",
+            "PREAPPROVED",
+            "WITH_ISSUES",
+        ],
+    }
     new_config.pop("_limit", None)
     new_config.pop("end_date", None)
     return new_config
diff --git a/...ntegrations/connectors/source-facebook-marketing/integration_tests/expected_records.jsonl b/...ntegrations/connectors/source-facebook-marketing/integration_tests/expected_records.jsonl
diff --git a/...yte-integrations/connectors/source-facebook-marketing/integration_tests/future_state.json b/...yte-integrations/connectors/source-facebook-marketing/integration_tests/future_state.json
@@ -4,7 +4,7 @@
     "stream": {
       "stream_state": {
         "event_time": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "activities"
@@ -16,7 +16,7 @@
     "stream": {
       "stream_state": {
         "updated_time": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": ["ARCHIVED"]
       },
       "stream_descriptor": {
         "name": "campaigns"
@@ -28,7 +28,7 @@
     "stream": {
       "stream_state": {
         "updated_time": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "images"
@@ -40,7 +40,7 @@
     "stream": {
       "stream_state": {
         "updated_time": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "videos"
@@ -52,7 +52,7 @@
     "stream": {
       "stream_state": {
         "updated_time": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ad_creatives"
@@ -64,7 +64,7 @@
     "stream": {
       "stream_state": {
         "updated_time": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": ["ARCHIVED"]
       },
       "stream_descriptor": {
         "name": "ad_sets"
@@ -76,7 +76,7 @@
     "stream": {
       "stream_state": {
         "updated_time": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": ["ARCHIVED"]
       },
       "stream_descriptor": {
         "name": "ads"
@@ -88,7 +88,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights"
@@ -100,7 +100,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_age_and_gender"
@@ -112,7 +112,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_country"
@@ -124,7 +124,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_dma"
@@ -136,7 +136,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_platform_and_device"
@@ -148,7 +148,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_region"
@@ -160,7 +160,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_action_type"
@@ -172,20 +172,19 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "custommy_custom_insights"
       }
     }
   },
-
   {
     "type": "STREAM",
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_action_carousel_card"
@@ -197,7 +196,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_action_conversion_device"
@@ -209,7 +208,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_action_product_id"
@@ -221,7 +220,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_action_reaction"
@@ -233,7 +232,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_action_video_sound"
@@ -245,7 +244,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_action_video_type"
@@ -257,7 +256,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_delivery_device"
@@ -269,7 +268,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_delivery_platform"
@@ -281,7 +280,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_delivery_platform_and_device_platform"
@@ -293,7 +292,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_demographics_age"
@@ -305,7 +304,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_demographics_country"
@@ -317,7 +316,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_demographics_dma_region"
@@ -329,7 +328,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "ads_insights_demographics_gender"
@@ -341,7 +340,7 @@
     "stream": {
       "stream_state": {
         "date_start": "2121-07-25T13:34:26Z",
-        "include_deleted": true
+        "filter_statuses": []
       },
       "stream_descriptor": {
         "name": "customcustom_insight_stream"

diff --git a/...e-integrations/connectors/source-facebook-marketing/integration_tests/invalid_config.json b/...e-integrations/connectors/source-facebook-marketing/integration_tests/invalid_config.json
@@ -1,6 +1,5 @@
 {
   "start_date": "2023-04-01T00:00:00Z",
   "account_id": "account",
-  "access_token": "wrong_token",
-  "include_deleted": true
+  "access_token": "wrong_token"
 }