-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into vitalii/1392_test_file_formats
# Conflicts: # airbyte-integrations/connectors/source-file/build.gradle # airbyte-integrations/connectors/source-file/integration_tests/integration_source_test.py # airbyte-integrations/connectors/source-file/setup.py # docs/integrations/sources/file.md
- Loading branch information
Showing
46 changed files
with
4,425 additions
and
820 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
145 changes: 145 additions & 0 deletions
145
...te-integrations/connectors/source-file/integration_tests/client_storage_providers_test.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| """ | ||
| MIT License | ||
| Copyright (c) 2020 Airbyte | ||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. | ||
| """ | ||
|
|
||
| import json | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
| from source_file.client import Client | ||
|
|
||
| HERE = Path(__file__).parent.absolute() | ||
|
|
||
|
|
||
| def check_read(config, expected_columns=10, expected_rows=42): | ||
| client = Client(**config) | ||
| rows = list(client.read()) | ||
| assert len(rows) == expected_rows | ||
| assert len(rows[0]) == expected_columns | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "provider_name,file_path,file_format", | ||
| [ | ||
| ("ssh", "files/test.csv", "csv"), | ||
| ("scp", "files/test.csv", "csv"), | ||
| ("sftp", "files/test.csv", "csv"), | ||
| ("ssh", "files/test.csv.gz", "csv"), # text in binary | ||
| ("ssh", "files/test.pkl", "pickle"), # binary | ||
| ("sftp", "files/test.pkl.gz", "pickle"), # binary in binary | ||
| ], | ||
| ) | ||
| def test__read_from_private_ssh(provider_config, provider_name, file_path, file_format): | ||
| client = Client(dataset_name="output", format=file_format, url=file_path, provider=provider_config(provider_name)) | ||
| result = next(client.read()) | ||
| assert result == {"header1": "text", "header2": 1, "header3": 0.2} | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "provider_name,file_path,file_format", | ||
| [ | ||
| ("ssh", "files/file_does_not_exist.csv", "csv"), | ||
| ("gcs", "gs://gcp-public-data-landsat/file_does_not_exist.csv", "csv"), | ||
| ], | ||
| ) | ||
| def test__read_file_not_found(provider_config, provider_name, file_path, file_format): | ||
| client = Client(dataset_name="output", format=file_format, url=file_path, provider=provider_config(provider_name)) | ||
| with pytest.raises(FileNotFoundError): | ||
| next(client.read()) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "provider_name, file_path, file_format", | ||
| [ | ||
| ("ssh", "files/test.csv", "csv"), | ||
| ("ssh", "files/test.pkl", "pickle"), | ||
| ("sftp", "files/test.pkl.gz", "pickle"), | ||
| ], | ||
| ) | ||
| def test__streams_from_ssh_providers(provider_config, provider_name, file_path, file_format): | ||
| client = Client(dataset_name="output", format=file_format, url=file_path, provider=provider_config(provider_name)) | ||
| streams = list(client.streams) | ||
| assert len(streams) == 1 | ||
| assert streams[0].json_schema["properties"] == { | ||
| "header1": {"type": "string"}, | ||
| "header2": {"type": "number"}, | ||
| "header3": {"type": "number"}, | ||
| } | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "storage_provider, url, columns_nb, separator, has_header", | ||
| [ | ||
| # epidemiology csv | ||
| ("HTTPS", "https://storage.googleapis.com/covid19-open-data/v2/latest/epidemiology.csv", 10, ",", True), | ||
| ("HTTPS", "storage.googleapis.com/covid19-open-data/v2/latest/epidemiology.csv", 10, ",", True), | ||
| ("local", "injected by tests", 10, ",", True), | ||
| # landsat compressed csv | ||
| ("GCS", "gs://gcp-public-data-landsat/index.csv.gz", 18, ",", True), | ||
| ("GCS", "gs://gcp-public-data-landsat/index.csv.gz", 18, ",", True), | ||
| # GDELT csv | ||
| ("S3", "s3://gdelt-open-data/events/20190914.export.csv", 58, "\\t", False), | ||
| ("S3", "s3://gdelt-open-data/events/20190914.export.csv", 58, "\\t", False), | ||
| ], | ||
| ) | ||
| def test__read_from_public_provider(download_gcs_public_data, storage_provider, url, columns_nb, separator, has_header): | ||
| # inject temp file path that was downloaded by the test as URL | ||
| url = download_gcs_public_data if storage_provider == "local" else url | ||
| config = { | ||
| "format": "csv", | ||
| "dataset_name": "output", | ||
| "reader_options": json.dumps({"sep": separator, "nrows": 42}), | ||
| "provider": {"storage": storage_provider}, | ||
| "url": url, | ||
| } | ||
|
|
||
| check_read(config, expected_columns=columns_nb) | ||
|
|
||
|
|
||
| def test__read_from_private_gcs(google_cloud_service_credentials, private_google_cloud_file): | ||
| config = { | ||
| "dataset_name": "output", | ||
| "format": "csv", | ||
| "url": private_google_cloud_file, | ||
| "reader_options": json.dumps({"sep": ",", "nrows": 42}), | ||
| "provider": { | ||
| "storage": "GCS", | ||
| "service_account_json": json.dumps(google_cloud_service_credentials), | ||
| }, | ||
| } | ||
| check_read(config) | ||
|
|
||
|
|
||
| def test__read_from_private_aws(aws_credentials, private_aws_file): | ||
| config = { | ||
| "dataset_name": "output", | ||
| "format": "csv", | ||
| "url": private_aws_file, | ||
| "reader_options": json.dumps({"sep": ",", "nrows": 42}), | ||
| "provider": { | ||
| "storage": "S3", | ||
| "aws_access_key_id": aws_credentials["aws_access_key_id"], | ||
| "aws_secret_access_key": aws_credentials["aws_secret_access_key"], | ||
| }, | ||
| } | ||
| check_read(config) |
2 changes: 1 addition & 1 deletion
2
airbyte-integrations/connectors/source-file/integration_tests/config.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.