🐛 Source Aha: fix schemas and integration test (#26666)

* fix schemas * bump connector version
airbytehq · May 26, 2023 · e94f3b0 · e94f3b0
1 parent 3443438
commit e94f3b0
Show file tree

Hide file tree

Showing 11 changed files with 38 additions and 12 deletions.
diff --git a/airbyte-integrations/connectors/source-aha/Dockerfile b/airbyte-integrations/connectors/source-aha/Dockerfile
@@ -34,5 +34,5 @@ COPY source_aha ./source_aha
 ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
 
-LABEL io.airbyte.version=0.1.0
+LABEL io.airbyte.version=0.2.0
 LABEL io.airbyte.name=airbyte/source-aha
diff --git a/airbyte-integrations/connectors/source-aha/acceptance-test-config.yml b/airbyte-integrations/connectors/source-aha/acceptance-test-config.yml
@@ -14,6 +14,8 @@ acceptance_tests:
   discovery:
     tests:
       - config_path: "secrets/config.json"
+        backward_compatibility_tests_config:
+          disable_for_version: "0.1.0"
   basic_read:
     tests:
       - config_path: "secrets/config.json"

diff --git a/airbyte-integrations/connectors/source-aha/metadata.yaml b/airbyte-integrations/connectors/source-aha/metadata.yaml
@@ -2,7 +2,7 @@ data:
   connectorSubtype: api
   connectorType: source
   definitionId: 81ca39dc-4534-4dd2-b848-b0cfd2c11fce
-  dockerImageTag: 0.1.0
+  dockerImageTag: 0.2.0
   dockerRepository: airbyte/source-aha
   githubIssueLabel: source-aha
   icon: aha.svg

diff --git a/airbyte-integrations/connectors/source-aha/setup.py b/airbyte-integrations/connectors/source-aha/setup.py
@@ -6,7 +6,7 @@
 from setuptools import find_packages, setup
 
 MAIN_REQUIREMENTS = [
-    "airbyte-cdk~=0.1",
+    "airbyte-cdk",
 ]
 
 TEST_REQUIREMENTS = [

diff --git a/airbyte-integrations/connectors/source-aha/source_aha/manifest.yaml b/airbyte-integrations/connectors/source-aha/source_aha/manifest.yaml
@@ -102,8 +102,4 @@ streams:
 
 check:
   stream_names:
-    - "features"
     - "products"
-    - "ideas"
-    - "users"
-    - "goals"
diff --git a/airbyte-integrations/connectors/source-aha/source_aha/schemas/features.json b/airbyte-integrations/connectors/source-aha/source_aha/schemas/features.json
@@ -1,6 +1,7 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
   "type": "object",
+  "additionalProperties": true,
   "properties": {
     "id": {
       "type": ["null", "string"]

diff --git a/airbyte-integrations/connectors/source-aha/source_aha/schemas/goals.json b/airbyte-integrations/connectors/source-aha/source_aha/schemas/goals.json
@@ -1,6 +1,7 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
   "type": "object",
+  "additionalProperties": true,
   "properties": {
     "id": {
       "type": ["null", "string"]
@@ -30,7 +31,7 @@
       "type": ["null", "string"]
     },
     "progress": {
-      "type": ["null", "string"]
+      "type": ["null", "number"]
     },
     "progress_source": {
       "type": ["null", "string"]
@@ -54,19 +55,38 @@
       "type": ["null", "object"]
     },
     "initiatives": {
-      "type": ["null", "array"]
+      "type": ["null", "array"],
+      "items": {
+        "type": ["null", "object"],
+        "additionalProperties": true
+      }
     },
     "comments_count": {
       "type": ["null", "integer"]
     },
     "features": {
-      "type": ["null", "array"]
+      "type": ["null", "array"],
+      "items": {
+        "type": ["null", "object"],
+        "additionalProperties": true
+      }
     },
     "releases": {
       "type": ["null", "array"]
     },
     "custom_fields": {
       "type": ["null", "array"]
+    },
+    "parent": {
+      "type": ["null", "object"],
+      "additionalProperties": true
+    },
+    "parents": {
+      "type": ["null", "array"],
+      "items": {
+        "type": ["null", "object"],
+        "additionalProperties": true
+      }
     }
   }
 }
diff --git a/airbyte-integrations/connectors/source-aha/source_aha/schemas/ideas.json b/airbyte-integrations/connectors/source-aha/source_aha/schemas/ideas.json
@@ -1,10 +1,14 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
   "type": "object",
+  "additionalProperties": true,
   "properties": {
     "id": {
       "type": ["null", "string"]
     },
+    "name": {
+      "type": ["null", "string"]
+    },
     "reference_num": {
       "type": ["null", "string"]
     },
@@ -15,7 +19,7 @@
       "type": ["null", "string"]
     },
     "workflow_status": {
-      "type": "object",
+      "type": ["null", "object"],
       "properties": {
         "id": {
           "type": ["null", "string"]
@@ -35,7 +39,7 @@
       }
     },
     "description": {
-      "type": "object",
+      "type": ["null", "object"],
       "properties": {
         "id": {
           "type": ["null", "string"]

diff --git a/airbyte-integrations/connectors/source-aha/source_aha/schemas/products.json b/airbyte-integrations/connectors/source-aha/source_aha/schemas/products.json
@@ -1,6 +1,7 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
   "type": "object",
+  "additionalProperties": true,
   "properties": {
     "id": {
       "type": ["null", "string"]

diff --git a/airbyte-integrations/connectors/source-aha/source_aha/schemas/users.json b/airbyte-integrations/connectors/source-aha/source_aha/schemas/users.json
@@ -1,6 +1,7 @@
 {
   "$schema": "http://json-schema.org/draft-07/schema#",
   "type": "object",
+  "additionalProperties": true,
   "properties": {
     "id": {
       "type": ["null", "string"]

diff --git a/docs/integrations/sources/aha.md b/docs/integrations/sources/aha.md
@@ -37,4 +37,5 @@ Rate Limiting information is updated [here](https://www.aha.io/api#rate-limiting
 
 | Version | Date       | Pull Request                                             | Subject                                         |
 |:--------|:-----------|:---------------------------------------------------------|:------------------------------------------------|
+| 0.2.0   | 2023-05-26 | [26666](https://github.com/airbytehq/airbyte/pull/26666) | Fix integration test and schemas                |
 | 0.1.0   | 2022-11-02 | [18883](https://github.com/airbytehq/airbyte/pull/18893) | 🎉 New Source: Aha                              |