Revert "Make email a required field in the onboarding flow (#2814)" (#…

…2858) This reverts commit 616d55d.
airbytehq · Apr 12, 2021 · ea21c34 · ea21c34
1 parent e11ccfd
commit ea21c34
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/airbyte-e2e-testing/cypress/integration/onboarding.spec.js b/airbyte-e2e-testing/cypress/integration/onboarding.spec.js
@@ -3,9 +3,7 @@ describe("Onboarding actions", () => {
     cy.visit("/");
     cy.url().should("include", `${Cypress.config().baseUrl}/preferences`);
 
-    cy.fillEmail("test-email-onboarding@test-onboarding-domain.com");
-    cy.get("input[name=securityUpdates]").parent().click();
-
+    // cy.fillEmail("");
     cy.submit();
 
     cy.url().should("include", `${Cypress.config().baseUrl}/onboarding`);

diff --git a/airbyte-webapp/src/components/PreferencesForm/PreferencesForm.tsx b/airbyte-webapp/src/components/PreferencesForm/PreferencesForm.tsx
@@ -57,7 +57,7 @@ const Text = styled.div`
 `;
 
 const preferencesValidationSchema = yup.object().shape({
-  email: yup.string().email("form.email.error").required("form.empty.error"),
+  email: yup.string().email("form.email.error"),
 });
 
 const PreferencesForm: React.FC<PreferencesFormProps> = ({
@@ -100,7 +100,7 @@ const PreferencesForm: React.FC<PreferencesFormProps> = ({
               {({ field, meta }: FieldProps<string>) => (
                 <LabeledInput
                   {...field}
-                  label={<FormattedMessage id="form.yourEmail" />}
+                  label={<FormattedMessage id="form.emailOptional" />}
                   placeholder={formatMessage({
                     id: "form.email.placeholder",
                   })}
@@ -113,9 +113,6 @@ const PreferencesForm: React.FC<PreferencesFormProps> = ({
                   }
                   onChange={(event) => {
                     handleChange(event);
-                    if (isEdit) {
-                      return;
-                    }
                     if (
                       field.value.length === 0 &&
                       event.target.value.length > 0

diff --git a/airbyte-webapp/src/locales/en.json b/airbyte-webapp/src/locales/en.json
@@ -11,7 +11,7 @@
   "sidebar.settings": "Settings",
 
   "form.continue": "Continue",
-  "form.yourEmail": "Your email",
+  "form.emailOptional": "Your email (optional)",
   "form.email.placeholder": "you@company.com",
   "form.email.error": "This email address doesn’t seem correct.",
   "form.empty.error": "Empty field",