Source Postgres: Fix not being able to configure wal2json plugin (unp…

…ublished) (#19985) * switch const to default * update expected specs * try updating system-stubs? * Revert "try updating system-stubs?" This reverts commit 0311a5a. * switch to system stubs * changelog * fix more tests
airbytehq · Dec 6, 2022 · ea3fb89 · ea3fb89
1 parent 94477e4
commit ea3fb89
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 5 deletions.
diff --git a/.../integrations/io/airbyte/integration_tests/sources/CdcBinlogsMySqlSourceDatatypeTest.java b/.../integrations/io/airbyte/integration_tests/sources/CdcBinlogsMySqlSourceDatatypeTest.java
@@ -45,7 +45,7 @@ protected List<AirbyteMessage> runRead(final ConfiguredAirbyteCatalog configured
   }
 
   @Override
-  protected void setupEnvironment(final TestDestinationEnv environment) throws Exception {
+  protected void postSetup() throws Exception {
     final Database database = setupDatabase();
     initTests();
     for (final TestDataHolder test : testDataHolders) {

diff --git a/airbyte-integrations/connectors/source-postgres/src/main/resources/spec.json b/airbyte-integrations/connectors/source-postgres/src/main/resources/spec.json
@@ -247,7 +247,7 @@
                 "title": "Plugin",
                 "description": "A logical decoding plugin installed on the PostgreSQL server. The `pgoutput` plugin is used by default. If the replication table contains a lot of big jsonb values it is recommended to use `wal2json` plugin. Read more about <a href=\"https://docs.airbyte.com/integrations/sources/postgres#step-2-select-a-replication-plugin\">selecting replication plugins</a>.",
                 "enum": ["pgoutput", "wal2json"],
-                "const": "pgoutput",
+                "default": "pgoutput",
                 "order": 2
               },
               "replication_slot": {

diff --git a/...integrations/connectors/source-postgres/src/test-integration/resources/expected_spec.json b/...integrations/connectors/source-postgres/src/test-integration/resources/expected_spec.json
@@ -247,7 +247,7 @@
                 "title": "Plugin",
                 "description": "A logical decoding plugin installed on the PostgreSQL server. The `pgoutput` plugin is used by default. If the replication table contains a lot of big jsonb values it is recommended to use `wal2json` plugin. Read more about <a href=\"https://docs.airbyte.com/integrations/sources/postgres#step-2-select-a-replication-plugin\">selecting replication plugins</a>.",
                 "enum": ["pgoutput", "wal2json"],
-                "const": "pgoutput",
+                "default": "pgoutput",
                 "order": 2
               },
               "replication_slot": {

diff --git a/...nnectors/source-postgres/src/test-integration/resources/expected_strict_encrypt_spec.json b/...nnectors/source-postgres/src/test-integration/resources/expected_strict_encrypt_spec.json
@@ -227,7 +227,7 @@
                 "title": "Plugin",
                 "description": "A logical decoding plugin installed on the PostgreSQL server. The `pgoutput` plugin is used by default. If the replication table contains a lot of big jsonb values it is recommended to use `wal2json` plugin. Read more about <a href=\"https://docs.airbyte.com/integrations/sources/postgres#step-2-select-a-replication-plugin\">selecting replication plugins</a>.",
                 "enum": ["pgoutput", "wal2json"],
-                "const": "pgoutput",
+                "default": "pgoutput",
                 "order": 2
               },
               "replication_slot": {

diff --git a/airbyte-integrations/connectors/source-postgres/src/test/resources/expected_spec.json b/airbyte-integrations/connectors/source-postgres/src/test/resources/expected_spec.json
@@ -227,7 +227,7 @@
                 "title": "Plugin",
                 "description": "A logical decoding plugin installed on the PostgreSQL server. The `pgoutput` plugin is used by default. If the replication table contains a lot of big jsonb values it is recommended to use `wal2json` plugin. Read more about <a href=\"https://docs.airbyte.com/integrations/sources/postgres#step-2-select-a-replication-plugin\">selecting replication plugins</a>.",
                 "enum": ["pgoutput", "wal2json"],
-                "const": "pgoutput",
+                "default": "pgoutput",
                 "order": 2
               },
               "replication_slot": {

diff --git a/docs/integrations/sources/postgres.md b/docs/integrations/sources/postgres.md
@@ -415,6 +415,7 @@ The root causes is that the WALs needed for the incremental sync has been remove
 
 | Version | Date       | Pull Request                                                                                                       | Subject                                                                                                                                                                    |
 |:--------|:-----------|:-------------------------------------------------------------------------------------------------------------------|:---------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| (none)  | 2022-12-02 | [19985](https://github.com/airbytehq/airbyte/pull/19985)                                                           | Reenable incorrectly-disabled `wal2json` CDC plugin                                                                                                                        |
 | 1.0.30  | 2022-11-29 | [19024](https://github.com/airbytehq/airbyte/pull/19024)                                                           | Skip tables from schema where user do not have Usage permission during discovery.                                                                                          |
 | 1.0.29  | 2022-11-29 | [19623](https://github.com/airbytehq/airbyte/pull/19623)                                                           | Mark PSQLException related to using replica that is configured as a hot standby server as config error.                                                                    |
 | 1.0.28  | 2022-11-28 | [19514](https://github.com/airbytehq/airbyte/pull/19514)                                                           | Adjust batch selection memory limits databases.                                                                                                                            |