Skip to content

Commit

Permalink
馃悰 Fix URL pattern regex in Google PageSpeed Insights connector (#22287)
Browse files Browse the repository at this point in the history
* Fix URL pattern regex in Google PageSpeed Insights connector

Without this `[` escaped, setting up a new source results in `java.util.regex.PatternSyntaxException: Unclosed character class`

* Bump source-google-pagespeed-insights version to 0.1.1

* fix: correct validation errors in acceptance-test-config.yml

* docs: bump metadata.yml file and update connector changelog

---------

Co-authored-by: Sajarin <sajarindider@gmail.com>
  • Loading branch information
reidab and sajarin committed May 26, 2023
1 parent 8932684 commit ea7bd02
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ COPY source_google_pagespeed_insights ./source_google_pagespeed_insights
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.0
LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.name=airbyte/source-google-pagespeed-insights
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,8 @@ acceptance_tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
ignored_fields:
pagespeed: ["lighthouseResult", "analysisUTCTimestamp"] # This differs between two runs, as they are newly generated per run
pagespeed:
- name: lighthouseResult
bypass_reason: "This differs between two runs, as they are newly generated per run"
- name: analysisUTCTimestamp
bypass_reason: "This differs between two runs, as they are newly generated per run"
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 1e9086ab-ddac-4c1d-aafd-ba43ff575fe4
dockerImageTag: 0.1.0
dockerImageTag: 0.1.1
dockerRepository: airbyte/source-google-pagespeed-insights
githubIssueLabel: source-google-pagespeed-insights
icon: google-pagespeed-insights.svg
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ connectionSpecification:
type: array
items:
type: string
pattern: ^(?:origin:)?(http(s)?:\/\/)[\w.-]+(?:\.[\w\.-]+)+[\w\-\._~:\/?#[\]@!\$&'\(\)\*\+,;=.]+$
pattern: ^(?:origin:)?(http(s)?:\/\/)[\w.-]+(?:\.[\w\.-]+)+[\w\-\._~:\/?#\[\]@!\$&'\(\)\*\+,;=.]+$
title: URLs to analyse
description: >-
The URLs to retrieve pagespeed information from. The connector will attempt to sync
Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/google-pagespeed-insights.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,5 @@ If the connector is used with an API key, Google allows for 25.000 queries per d

| Version | Date | Pull Request | Subject |
| :------ | :--------- | :-------------------------------------------------------- | :----------------------------------------- |
| 0.1.1 | 2023-05-25 | [#22287](https://github.com/airbytehq/airbyte/pull/22287) | 馃悰 Fix URL pattern regex |
| 0.1.0 | 2022-11-26 | [#19813](https://github.com/airbytehq/airbyte/pull/19813) | 馃帀 New Source: Google PageSpeed Insights [low-code CDK] |

0 comments on commit ea7bd02

Please sign in to comment.