Skip to content

Commit

Permalink
Source Okta: OAuth2.0 support - disabled (#20877)
Browse files Browse the repository at this point in the history
* Disabled OAuth Okta

* Updated acceptance tests

* Updated PR number

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
  • Loading branch information
lazebnyi and octavia-squidington-iii committed Jan 6, 2023
1 parent 1601e32 commit f9fc56c
Show file tree
Hide file tree
Showing 10 changed files with 194 additions and 133 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1073,7 +1073,7 @@
- name: Okta
sourceDefinitionId: 1d4fdb25-64fc-4569-92da-fcdca79a8372
dockerRepository: airbyte/source-okta
dockerImageTag: 0.1.13
dockerImageTag: 0.1.14
documentationUrl: https://docs.airbyte.com/integrations/sources/okta
icon: okta.svg
sourceType: api
Expand Down
48 changes: 1 addition & 47 deletions airbyte-config/init/src/main/resources/seed/source_specs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9848,7 +9848,7 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
- dockerImage: "airbyte/source-okta:0.1.13"
- dockerImage: "airbyte/source-okta:0.1.14"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/okta"
connectionSpecification:
Expand Down Expand Up @@ -9923,52 +9923,6 @@
supportsNormalization: false
supportsDBT: false
supported_destination_sync_modes: []
advanced_auth:
auth_flow_type: "oauth2.0"
predicate_key:
- "credentials"
- "auth_type"
predicate_value: "oauth2.0"
oauth_config_specification:
oauth_user_input_from_connector_config_specification:
type: "object"
additionalProperties: true
properties:
domain:
type: "string"
path_in_connector_config:
- "domain"
complete_oauth_output_specification:
type: "object"
additionalProperties: true
properties:
refresh_token:
type: "string"
path_in_connector_config:
- "credentials"
- "refresh_token"
complete_oauth_server_input_specification:
type: "object"
additionalProperties: true
properties:
client_id:
type: "string"
client_secret:
type: "string"
complete_oauth_server_output_specification:
type: "object"
additionalProperties: true
properties:
client_id:
type: "string"
path_in_connector_config:
- "credentials"
- "client_id"
client_secret:
type: "string"
path_in_connector_config:
- "credentials"
- "client_secret"
- dockerImage: "airbyte/source-omnisend:0.1.0"
spec:
documentationUrl: "https://docs.airbyte.com/integrations/sources/omnisend"
Expand Down
2 changes: 1 addition & 1 deletion airbyte-integrations/connectors/source-okta/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.13
LABEL io.airbyte.version=0.1.14
LABEL io.airbyte.name=airbyte/source-okta
Original file line number Diff line number Diff line change
@@ -1,29 +1,37 @@
connector_image: airbyte/source-okta:dev
tests:
test_strictness_level: high
acceptance_tests:
spec:
- spec_path: "source_okta/spec.json"
tests:
- spec_path: "source_okta/spec.json"
connection:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "secrets/config_api_token.json"
status: "succeed"
- config_path: "secrets/config_oauth.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
tests:
- config_path: "secrets/config.json"
status: "succeed"
- config_path: "secrets/config_api_token.json"
status: "succeed"
- config_path: "secrets/config_oauth.json"
status: "succeed"
- config_path: "integration_tests/invalid_config.json"
status: "failed"
discovery:
- config_path: "secrets/config.json"
tests:
- config_path: "secrets/config.json"
basic_read:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
expect_records:
path: "integration_tests/expected_records.jsonl"
- config_path: "secrets/config_api_token.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
tests:
- config_path: "secrets/config.json"
expect_records:
path: "integration_tests/expected_records.jsonl"
extra_fields: no
exact_order: no
extra_records: yes
full_refresh:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
incremental:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/configured_catalog.json"
future_state_path: "integration_tests/abnormal_state.json"
tests:
- config_path: "secrets/config.json"
configured_catalog_path: "integration_tests/incremental_configured_catalog.json"
future_state:
future_state_path: "integration_tests/abnormal_state.json"
Original file line number Diff line number Diff line change
@@ -1,7 +1,57 @@
{
"users": { "lastUpdated": "3021-09-08T07:04:28.000Z" },
"groups": { "lastUpdated": "3021-09-08T07:04:28.000Z" },
"group_members": { "id": "00uzzzzzzzzzzzzzzzzz" },
"logs": { "published": "3021-09-08T07:04:28.000Z" },
"resource_sets": { "id": "iamzzzzzzzzzzzzzzzzz" }
}
[
{
"type": "STREAM",
"stream": {
"stream_state": {
"lastUpdated": "3021-09-08T07:04:28.000Z"
},
"stream_descriptor": {
"name": "users"
}
}
},
{
"type": "STREAM",
"stream": {
"stream_state": {
"lastUpdated": "3021-09-08T07:04:28.000Z"
},
"stream_descriptor": {
"name": "groups"
}
}
},
{
"type": "STREAM",
"stream": {
"stream_state": {
"id": "00uzzzzzzzzzzzzzzzzz"
},
"stream_descriptor": {
"name": "group_members"
}
}
},
{
"type": "STREAM",
"stream": {
"stream_state": {
"published": "3021-09-08T07:04:28.000Z"
},
"stream_descriptor": {
"name": "logs"
}
}
},
{
"type": "STREAM",
"stream": {
"stream_state": {
"id": "iamzzzzzzzzzzzzzzzzz"
},
"stream_descriptor": {
"name": "resource_sets"
}
}
}
]
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,17 @@
"sync_mode": "full_refresh",
"destination_sync_mode": "overwrite",
"primary_key": [["label"]]
},
{
"stream": {
"name": "logs",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"]
},
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"cursor_field": ["published"],
"primary_key": [["uuid"]]
}
]
}

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
{
"streams": [
{
"stream": {
"name": "users",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"]
},
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"cursor_field": ["lastUpdated"],
"primary_key": [["id"]]
},
{
"stream": {
"name": "groups",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"]
},
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"cursor_field": ["lastUpdated"],
"primary_key": [["id"]]
},
{
"stream": {
"name": "group_members",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"]
},
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"cursor_field": ["id"],
"primary_key": [["id"]]
},
{
"stream": {
"name": "resource_sets",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"]
},
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"cursor_field": ["id"],
"primary_key": [["id"]]
},
{
"stream": {
"name": "logs",
"json_schema": {},
"supported_sync_modes": ["full_refresh", "incremental"]
},
"sync_mode": "incremental",
"destination_sync_mode": "overwrite",
"cursor_field": ["published"],
"primary_key": [["uuid"]]
}
]
}
53 changes: 0 additions & 53 deletions airbyte-integrations/connectors/source-okta/source_okta/spec.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,58 +80,5 @@
]
}
}
},
"advanced_auth": {
"auth_flow_type": "oauth2.0",
"predicate_key": ["credentials", "auth_type"],
"predicate_value": "oauth2.0",
"oauth_config_specification": {
"complete_oauth_output_specification": {
"type": "object",
"additionalProperties": true,
"properties": {
"refresh_token": {
"type": "string",
"path_in_connector_config": ["credentials", "refresh_token"]
}
}
},
"complete_oauth_server_input_specification": {
"type": "object",
"additionalProperties": true,
"properties": {
"client_id": {
"type": "string"
},
"client_secret": {
"type": "string"
}
}
},
"complete_oauth_server_output_specification": {
"type": "object",
"additionalProperties": true,
"properties": {
"client_id": {
"type": "string",
"path_in_connector_config": ["credentials", "client_id"]
},
"client_secret": {
"type": "string",
"path_in_connector_config": ["credentials", "client_secret"]
}
}
},
"oauth_user_input_from_connector_config_specification": {
"type": "object",
"additionalProperties": true,
"properties": {
"domain": {
"type": "string",
"path_in_connector_config": ["domain"]
}
}
}
}
}
}
3 changes: 2 additions & 1 deletion docs/integrations/sources/okta.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ The connector is restricted by normal Okta [requests limitation](https://develop

| Version | Date | Pull Request | Subject |
|:--------|:-----------|:---------------------------------------------------------|:-------------------------------------------------------------------------------|
| 0.1.13 | 2022-08-12 | [14700](https://github.com/airbytehq/airbyte/pull/14700) | Add resource sets |
| 0.1.14 | 2022-12-24 | [20877](https://github.com/airbytehq/airbyte/pull/20877) | Disabled OAuth2.0 authorization method |
| 0.1.13 | 2022-08-12 | [14700](https://github.com/airbytehq/airbyte/pull/14700) | Add resource sets |
| 0.1.12 | 2022-08-05 | [15050](https://github.com/airbytehq/airbyte/pull/15050) | Add parameter `start_date` for Logs stream |
| 0.1.11 | 2022-08-03 | [14739](https://github.com/airbytehq/airbyte/pull/14739) | Add permissions for custom roles |
| 0.1.10 | 2022-08-01 | [15179](https://github.com/airbytehq/airbyte/pull/15179) | Fix broken schemas for all streams |
Expand Down

0 comments on commit f9fc56c

Please sign in to comment.