External Secrets Store Support: AWS Secrets Manager #10518
Labels
accepting-contributions
Feel free to contribute to them
area/platform
issues related to the platform
team/compose
team/platform-move
type/enhancement
New feature or request
Comments
cgardens
added
type/enhancement
3 tasks
4 tasks
5 tasks
pmossman
pushed a commit
that referenced
this issue
Dec 1, 2022
#10518 Added new implementation AWSSecretManagerPersistence and integration tests AWSSecretManagerPersistenceIntegrationTest A new implementation of SecretPersistence to support AWS Secret Manager AWSSecretManagerPersistence New Integration tests as suggested on the open Issue, similar to GCP secret manager
pmossman
pushed a commit
that referenced
this issue
Dec 2, 2022
#10518 Added new implementation AWSSecretManagerPersistence and integration tests AWSSecretManagerPersistenceIntegrationTest A new implementation of SecretPersistence to support AWS Secret Manager AWSSecretManagerPersistence New Integration tests as suggested on the open Issue, similar to GCP secret manager
pmossman
pushed a commit
that referenced
this issue
Dec 9, 2022
#10518 Added new implementation AWSSecretManagerPersistence and integration tests AWSSecretManagerPersistenceIntegrationTest A new implementation of SecretPersistence to support AWS Secret Manager AWSSecretManagerPersistence New Integration tests as suggested on the open Issue, similar to GCP secret manager
pmossman
pushed a commit
to mauricioalarcon/airbyte
that referenced
this issue
Dec 12, 2022
airbytehq#10518 Added new implementation AWSSecretManagerPersistence and integration tests AWSSecretManagerPersistenceIntegrationTest A new implementation of SecretPersistence to support AWS Secret Manager AWSSecretManagerPersistence New Integration tests as suggested on the open Issue, similar to GCP secret manager
pmossman
pushed a commit
to mauricioalarcon/airbyte
that referenced
this issue
Dec 12, 2022
airbytehq#10518 Added new implementation AWSSecretManagerPersistence and integration tests AWSSecretManagerPersistenceIntegrationTest A new implementation of SecretPersistence to support AWS Secret Manager AWSSecretManagerPersistence New Integration tests as suggested on the open Issue, similar to GCP secret manager
pmossman
added a commit
that referenced
this issue
Dec 12, 2022
* 🎉 New implementation for AWS Secret Manager for issue #10518 Added new implementation AWSSecretManagerPersistence and integration tests AWSSecretManagerPersistenceIntegrationTest A new implementation of SecretPersistence to support AWS Secret Manager AWSSecretManagerPersistence New Integration tests as suggested on the open Issue, similar to GCP secret manager * Updated version to `aws-secretsmanager-caching-java:1.0.2` - Added new argument check for AWS Secret Manager. * exclude jackson-databind from aws dependency and run gradle format * bump aws-related dependencies to prevent old version of jackson-databind from being pulled in * - Added new entry for `AWS_SECRET_MANAGER` into SecretPersistence.java - Externalized configurations for AWS Secret Manager into Configs and EnvConfigs.java as requested. - Adjusted test to use new constructor for `AWSSecretManagerPersistence` - Augmented instructions configuring-airbyte.md with the new config keys. * Formatting code. * revert dependency version bump Co-authored-by: pmossman <parker@airbyte.io> Co-authored-by: mauricioalarcon <unknown>
|
This is done! |
|
fyi @tryangul I saw this was referenced in a recent customer conversation and is now completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
epic: #837
Tell us about the problem you're trying to solve
Currently, Airbyte only integrates with one external secrets store: GCP Secrets Manager. Users on AWS prefer to use AWS Secrets Manager.
Describe the solution you’d like
Add AWS Secrets Manager as an option for external secrets.
Describe the alternative you’ve considered or used
A clear and concise description of any alternative solutions or features you've considered or are using today. We already have a
SecretsPersistenceinterface to work with. The existing GCP Secrets Manager implementation can be found in the classGoogleSecretManagerPersistence. Basically we need to:SecretsPersistencefor AWS Secrets Manager with tests similar to what already exists.In terms of external contribution part 1 should be very doable. We would be happy to help on part 2 once tests are passing for part 1.
The text was updated successfully, but these errors were encountered: