Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make source/destinations tab present in the URL #11102

Closed
timroes opened this issue Mar 14, 2022 · 2 comments
Closed

Make source/destinations tab present in the URL #11102

timroes opened this issue Mar 14, 2022 · 2 comments
Assignees
@edmundito
Labels
area/frontend Related to the Airbyte webapp autoteam

Comments

@timroes
Copy link
Collaborator

timroes commented Mar 14, 2022

Currently when visting an individual's source or destinations page, it's not part of the URL whether the user is on the "Overview" tab or the "Settings" tab. This makes it hard to link to them from our documentation and we should reflect that tab within the URL, so we're able for documentation and support to link to a page directly.
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@bleonard bleonard added autoteam area/frontend Related to the Airbyte webapp labels Apr 27, 2022
@edmundito
Copy link
Contributor

This issue was actually resolved in #12253 when the confirmation modal was added. The paths are:

Overview: workspaces/:workspaceId/souce|destinaton/:sourceOrDestinationId
Settings: workspaces/:workspaceId/souce|destinaton/:sourceOrDestinationId/settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edmundito edmundito

Labels
area/frontend Related to the Airbyte webapp autoteam
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bleonard @edmundito @timroes @octavia-squidington-iii