Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation paths for source and destination item pages #12253

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

edmundito
Copy link
Contributor

What

Fixes an issue introduced in #12186 where the navigation to the settings page was no longer working as expected

How

Fixes the path such that it navigates to the relative path of the current page. root is the landing page, and /settings/ is the settings page. Tested in cloud and OSS.

Recommended reading order

As-is

@edmundito edmundito requested a review from a team as a code owner April 21, 2022 20:05
@github-actions github-actions bot added the area/platform issues related to the platform label Apr 21, 2022
Copy link
Contributor

@krishnaglick krishnaglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants