Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github source not failing on critical error #1129

Closed
sherifnada opened this issue Nov 30, 2020 · 2 comments · Fixed by #2050
Closed

Github source not failing on critical error #1129

sherifnada opened this issue Nov 30, 2020 · 2 comments · Fixed by #2050
Assignees
@vitaliizazmic
Labels
connectors/source/github connectors/sources-api type/bug Something isn't working

Comments

@sherifnada
Copy link
Contributor

Expected Behavior

Child of #1082 : Github source encounters a critical error but the worker still shows up as succeeded in the UI.

Relevant exception:

2020-11-25 05:10:27 ERROR (/tmp/workspace/20/0) DefaultAirbyteStreamFactory(internalLog):108 - CRITICAL {"message":"Must have push access to view repository
@sherifnada sherifnada added the type/bug Something isn't working label Nov 30, 2020
@cgardens cgardens modified the milestones: v0.12.0, Launch 1.0 Jan 19, 2021
@vitaliizazmic
Copy link
Contributor

The estimate time to complete this task is 3h

@vitaliizazmic
Copy link
Contributor

Duplicate #1349

@cgardens cgardens removed this from the Beta Launch milestone Feb 1, 2021
@sherifnada sherifnada mentioned this issue Feb 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliizazmic vitaliizazmic

Labels
connectors/source/github connectors/sources-api type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Base Python: fail if underlying singer command fails airbytehq/airbyte
4 participants
@sherifnada @cgardens @vitaliizazmic @igrankova