Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github connector silently fails if the input token does not have required permissions #1349

Closed
sherifnada opened this issue Dec 16, 2020 · 2 comments
Assignees
Labels
type/bug Something isn't working

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Dec 16, 2020

Description

This was seen in #1082 , point no.3 in the issue created. The GH connector didn't have permissions to access the requested resources (which should have failed the job) but the job succeeded.

Acceptance Criteria for this issue:

  1. Reliably recreate the problem (and describe how it can be recreated in this issue)
  2. Implement solution
@sherifnada sherifnada added the type/bug Something isn't working label Dec 16, 2020
@arhip11 arhip11 assigned arhip11 and vitaliizazmic and unassigned arhip11 Dec 22, 2020
@vitaliizazmic
Copy link
Contributor

Root issue doesn't have full log record. But the same issue may arise while syncing collaborators stream. If user isn't one of them Github API v3 will return response 403 forbidden
{
"message": "Must have push access to view repository collaborators.",
"documentation_url": "https://docs.github.com/rest/reference/repos#list-repository-collaborators"
}
In this case Github Singer Tap raises AuthException error
https://github.com/singer-io/tap-github/blob/2cc18761fa3ed6d3c51da66535fbab68f8102d1e/tap_github/__init__.py#L107
But there isn't handling of error. And Singer Tap fails.
To fix this issue we need change source code of Github Singer Tap.

vitaliizazmic added a commit to vitaliizazmic/airbyte that referenced this issue Dec 28, 2020
vitaliizazmic added a commit to vitaliizazmic/airbyte that referenced this issue Dec 28, 2020
vitaliizazmic added a commit to vitaliizazmic/airbyte that referenced this issue Dec 28, 2020
vitaliizazmic added a commit to vitaliizazmic/airbyte that referenced this issue Dec 29, 2020
vitaliizazmic added a commit to vitaliizazmic/airbyte that referenced this issue Dec 29, 2020
vitaliizazmic added a commit to vitaliizazmic/airbyte that referenced this issue Dec 29, 2020
@sherifnada sherifnada linked a pull request Dec 29, 2020 that will close this issue
12 tasks
vitaliizazmic added a commit to vitaliizazmic/airbyte that referenced this issue Jan 5, 2021
vitaliizazmic added a commit to vitaliizazmic/airbyte that referenced this issue Jan 5, 2021
@sherifnada
Copy link
Contributor Author

closed in #1516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants