Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all available file formats and providers in source file #1392

Closed
sherifnada opened this issue Dec 18, 2020 · 2 comments
Closed

Test all available file formats and providers in source file #1392

sherifnada opened this issue Dec 18, 2020 · 2 comments
Assignees
Labels
area/connectors Connector related issues type/enhancement New feature or request

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Dec 18, 2020

Tell us about the problem you're trying to solve

Source-file supports the following file formats:

  "csv",
  "json",
  "html",
  "excel",
  "feather",
  "parquet",
  "orc",
  "pickle"

and the following storage providers:

HTTPS
GCS
S3
SFTP
SSH
WebHDFS
Local filesystem

The connector is built on top of the smart-open package which is why it can support such a wide variety of files and providers. We'd like to use automated testing to verify all those options are working.

Acceptance Criteria

  1. For each file format, place one instance of that file format on the local file system and write a test case to pull this file and verify the output is correct.
  2. For each storage provider, place a simple CSV file on this storage provider and write a test case to pull from it.
  3. Add credentials as needed to the .test-command.yml github workflow and the ci_credentials.sh script.

Feel free to break up the solution into as many PRs as needed

@sherifnada sherifnada added type/enhancement New feature or request area/connectors Connector related issues zazmic labels Dec 18, 2020
@sherifnada
Copy link
Contributor Author

Blocked on providing credentials for any providers

@vitaliizazmic
Copy link
Contributor

The estimate time to complete this task is 9h

Acceptance Criteria

  1. Source files - 4h 30m
  2. Storage provider - 4h
  3. Add credentials - 30m

@sherifnada sherifnada added this to the Launch 1.0 milestone Jan 19, 2021
vitaliizazmic added a commit that referenced this issue Jan 22, 2021
vitaliizazmic added a commit that referenced this issue Jan 25, 2021
@sherifnada sherifnada reopened this Jan 29, 2021
@cgardens cgardens removed this from the Beta Launch milestone Feb 1, 2021
sherifnada added a commit that referenced this issue Feb 2, 2021
Co-authored-by: Sherif Nada <snadalive@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants