Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sendgrid source tests failing #1840

Closed
sherifnada opened this issue Jan 26, 2021 · 2 comments
Closed

Sendgrid source tests failing #1840

sherifnada opened this issue Jan 26, 2021 · 2 comments
Assignees
@yevhenii-ldv
Labels
connectors/source/sendgrid connectors/sources-api type/bug Something isn't working

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Jan 26, 2021 •
edited

Expected Behavior

CI for the sendgrid source connector should succeed

Current Behavior

https://github.com/airbytehq/airbyte/runs/1766740232?check_suite_focus=true it is currently failing

Acceptance criteria

  1. identify root cause
  2. implement fix
@sherifnada sherifnada added type/bug Something isn't working zazmic labels Jan 26, 2021
@eugene-kulak
Copy link
Contributor

probably account related

@yevhenii-ldv yevhenii-ldv self-assigned this Jan 26, 2021
@yevhenii-ldv
Copy link
Contributor

@sherifnada, I checked the access, this account exists and it is possible to reach it, but by streams:

lists
campaigns
contacts

I get a 403 status code.
Because of this, we do not receive a single record, and the tests crash.
I think the solution to this bug is changing the access rights to read the above streams for apikey, since using my own account and apikey launched the tests and they passed.

yevhenii-ldv added a commit that referenced this issue Feb 1, 2021
@yevhenii-ldv
#1840 Issue: add campaign stream to configured_catalog.json
c3f0bc7
sherifnada added a commit that referenced this issue Feb 2, 2021
@yevhenii-ldv @sherifnada
#1840 Issue: Update configured_catalog for Sendgrid for testing all s…
3316d38 
…treams (#1913)

Co-authored-by: Sherif Nada <snadalive@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yevhenii-ldv yevhenii-ldv

Labels
connectors/source/sendgrid connectors/sources-api type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sherifnada @yevhenii-ldv @eugene-kulak @igrankova