-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Pipedrive - Missing Product Tables + relations #19008
Comments
Thanks for the issue @emeagenciadigital, are you willing to create a PR with the added streams + missing relations? |
@sajarin I don't have the knowledge to do it myself. If it helps, for reference the singer tap of Pipedrive includes the following streams :
|
@YowanR I'd like to work on this issue |
Any progress on this, @vidaletti? Fixed the reward for this issue as well :) |
Hi @YowanR I'm already doing local tests. I believe next week I can release the PR |
Thanks !!! If you need testers I will be available .
On Sat, 14 Jan 2023 at 5:51 PM Sirleno Vidaletti ***@***.***> wrote:
Hi @YowanR <https://github.com/YowanR> I'm already doing local tests. I
believe next week I can release the PR
—
Reply to this email directly, view it on GitHub
<#19008 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEJOJFO2V2YKDY3WZ6DCUVDWSMUX5ANCNFSM6AAAAAARYD4GPE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Daniel Vengoechea
Head of Growth
e-me.co
…--
Pd: Conoce nuestra nueva página web www.e-me.co
<http://e-me.co/?utm_source=email-signature-pd&utm_medium=email&utm_campaign=email-signature-pd>
|
@natalyjazzviolin @sajarin can you take a look, please? |
hey @vidaletti you should be able to fork the airbyte repo and push changes to a branch in your forked copy and then make a PR on our repo based on that branch. Is this the process you're using? |
@sajarin yes, follow the documentation for developers and I did as below. But the return is a 403 |
@vidaletti you should push the pipesrive-deals-19008 branch to your forked repo and then navigate to the create pull request for airbytehq/airbyte and you should be able to create a PR. Make sure you enable commit access for maintainers when creating your PR. Hope this helps. |
Hi @YowanR any progress on this ? Let me know if you need testers |
In this PR #23789 |
no response from customer I think we can close it |
Tell us about the problem you're trying to solve
What are you trying to do, and why is it hard? A clear and concise description of what the problem is. Ex. I'm always frustrated when [THere is no way to get deal products, person related fields and deal related fields]
Describe the solution you’d like
Add the followign missing content fron the following api endpoints:
For missing products in deals:
The next to endpoints will help discovering the relation between a deal and a product.
- https://developers.pipedrive.com/docs/api/v1/Deals#getDealProducts
- https://developers.pipedrive.com/docs/api/v1/Products#getProductDeals
The "persons fields" table should contain the field pipedrive id, wich is named as KEY.
The "persons" table should columnized the custom fields KEY.
The text was updated successfully, but these errors were encountered: