Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connector Builder UI] show HTTP request method in the test panel request tab #19622

Closed
5 tasks
sherifnada opened this issue Nov 18, 2022 · 3 comments · Fixed by #20109
Closed
5 tasks

[Connector Builder UI] show HTTP request method in the test panel request tab #19622

sherifnada opened this issue Nov 18, 2022 · 3 comments · Fixed by #20109
Assignees
Labels

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Nov 18, 2022

Tell us about the problem you're trying to solve

The test panel request tab does not show the HTTP method (GET/PUT/etc..) of the outgoing request

Screen Shot 2022-11-18 at 1 56 30 PM

Describe the solution you’d like

I would like to see the HTTP method used in the request.

This issue builds on top of the changes of another issue #19735 which handles updating the log messages emitted during a sync to a low code connector.

Implementation Approach

This will require changes to the airbyte-connector-builder-server.

When the airbyte-connector-builder-server receives request log messages with the added method field, we'll need to translate it into response output by the server. We need to update the open_api.yaml HttpRequest object to include a field for method. We use the OpenAPI spec to generate the server input/output models used by the server code. We then need to generate new models using ./gradlew :airbyte-connector-builder-server:generateOpenApiPythonServer And finally update how we parse the LOG message to extract the HTTP method and include it in the outbound server response.

Acceptance Criteria

  • The open_api.yaml spec reflects the additional request method field
  • The newly generated models should reflect the updated spec
  • When making server requests, the HTTP response includes the request method
  • The newly generated client should reflect the updated spec
  • The request method should be reflected in the connector builder UI sidebar panel
@sherifnada
Copy link
Contributor Author

cc @brianjlai could be a good first issue

@brianjlai
Copy link
Contributor

this is a good one. i'll flesh this out and add this to grooming

@brianjlai
Copy link
Contributor

grooming notes:

  • add acceptance criteria
    • log message output is updated
    • open api spec updated
    • server emits new method in request object
    • reflected in the UI
  • look up if a UI change is required

@brianjlai brianjlai changed the title Lowcode CDK: show HTTP request method in the test panel request tab [Connector Builder UI] show HTTP request method in the test panel request tab Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants