Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Low Code CDK] the http method of the request should be included for LOG messages emitted during a sync when debug is enabled #19735

Closed
2 tasks
brianjlai opened this issue Nov 22, 2022 · 1 comment
Assignees
Labels

Comments

@brianjlai
Copy link
Contributor

Tell us about the problem you're trying to solve

In the Connector Builder UI, we are not displaying the HTTP method used by the request. The changes to the builder server will be handled as part of #19622 along with more context. This issue will be used to track the airbyte-cdk changes needed. When logging some field of the PreparedRequest we are not including the HTTP method (GET/PUT/etc..), but we should be.

Describe the solution you’d like

During a read of a connector, for each outbound request made to a partner API, I would like to see in the request LOG message emitted that it also includes the HTTP method used.

Implementation Approach

This will require a change to low code framework of the airbyte-cdk package which is responsible for processing syncs to based on a developer configured connector manifest.

In the airbyte-cdk SimpleRetriever, we need to update how we create LOG messages for outbound requests to include the method of the PreparedRequest. The airbyte-cdk Python package will then need to have a new version published.

Acceptance Criteria

  • When running a sync with the --debug flag enabled will include request LOG messages where the method is populated
  • A new minor version of the airbyte-cdk Python package should be published
@brianjlai brianjlai added type/enhancement New feature or request needs-triage labels Nov 22, 2022
@brianjlai brianjlai changed the title [Low Code CDK] [Low Code CDK] the http method of the request should be included for LOG messages emitted during a sync when debug is enabled Nov 22, 2022
@girarda
Copy link
Contributor

girarda commented Nov 29, 2022

sample command: python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json --debug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants