Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low Code Connector tutorial example config update #20047

Closed
ethanbrown3 opened this issue Dec 4, 2022 · 2 comments
Closed

Low Code Connector tutorial example config update #20047

ethanbrown3 opened this issue Dec 4, 2022 · 2 comments
Labels
area/documentation Improvements or additions to documentation autoteam community team/documentation type/enhancement New feature or request

Comments

@ethanbrown3
Copy link

Tell us about the documentation you'd like us to add or update.

I am going through the tutorial for the low-code connectors. There is an error with the datetime_format in the example exchange_rates_tutorial.yaml file (see here). The end_datetime object has datetime_format: "%Y-%m-%d %H:%M:%S.%f". If you run python main.py read --config secrets/config.json --catalog integration_tests/configured_catalog.json with this config you will get the following error:

...
raise ValueError(\"unconverted data remains: %s\" %\nValueError: unconverted data remains: +00:00\n", "failure_type": "system_error"}}}

If you
update the datetime to include the +00:00 offset ie datetime_format: "%Y-%m-%d %H:%M:%S.%f+00:00". It will work.

If applicable, add links to the relevant docs that should be updated

@ethanbrown3 ethanbrown3 added area/documentation Improvements or additions to documentation type/enhancement New feature or request labels Dec 4, 2022
@juweins
Copy link
Contributor

juweins commented Dec 5, 2022

Hi! I just went through the tutorial and was able to reproduce the error. Likewise, I made adjustments to the documentation as per your suggestion.

juweins added a commit to juweins/airbyte that referenced this issue Dec 5, 2022
Added the suggested solution from issuer.
@ethanbrown3
Copy link
Author

Awesome thanks!

marcosmarxm pushed a commit that referenced this issue Dec 8, 2022
* Update 5-incremental-reads.md in response of Issue #20047

Added the suggested solution from issuer.

* Updated 5-incremental-reads.md #2

Appended the suggested +00:00 into another occurence. Datetime format now corresponds to standards defined in ISO-8601.

* Fix: Low Code Connector tutorial yaml #20071
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation autoteam community team/documentation type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants