Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for normalization. #2048

Closed
cgardens opened this issue Feb 11, 2021 · 3 comments · Fixed by #2211
Closed

Add unit tests for normalization. #2048

cgardens opened this issue Feb 11, 2021 · 3 comments · Fixed by #2211
Assignees
@ChristopheDuong
Labels
priority/medium Medium priority type/enhancement New feature or request
Milestone
2021-02-26

Comments

@cgardens
Copy link
Contributor

Tell us about the problem you're trying to solve

  • The normalization code is essentially untested except for collateral testing by the destination standard tests.

Describe the solution you’d like

  • There's a lot of edge cases in this problem and we need more specific unit testing to ensure that we're fixing them. They require more specific tests than the standard tests can provide. This will help use the whack-a-mole problem, where we fix a bug in one destination only to cause another in a different one.
@cgardens cgardens added type/enhancement New feature or request priority/medium Medium priority labels Feb 11, 2021
@cgardens cgardens added this to the 2021/02/19 milestone Feb 15, 2021
@cgardens
Copy link
Contributor Author

i think this was closed by the recently merged PR?

@cgardens cgardens modified the milestones: 2021-02-19, 2021-02-26 Feb 23, 2021
ChristopheDuong added a commit that referenced this issue Feb 25, 2021
@ChristopheDuong
Add unit tests for normalization. #2048
00d6a57
@ChristopheDuong ChristopheDuong mentioned this issue Feb 25, 2021
Merged
@ChristopheDuong
Copy link
Contributor

i think this was closed by the recently merged PR?

I kept this issue open as I was going to add more tests on normalization too

@cgardens
Copy link
Contributor Author

kk, please leave that update in a comment at the end of the week in the future please.

ChristopheDuong added a commit that referenced this issue Feb 26, 2021
@ChristopheDuong
Add unit tests for normalization. #2048 (#2211)
79ce443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristopheDuong ChristopheDuong

Labels
priority/medium Medium priority type/enhancement New feature or request
Projects
None yet
Milestone
2021-02-26
Development

Successfully merging a pull request may close this issue.

Add unit tests for normalization. #2048 airbytehq/airbyte
2 participants
@ChristopheDuong @cgardens