Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Low-Code CDK] Fix SubstreamSlicer parameter assignment and throw errors when RequestOption is path. #21095

Closed
brianjlai opened this issue Jan 6, 2023 · 0 comments
Assignees
Labels
team/extensibility type/bug Something isn't working

Comments

@brianjlai
Copy link
Contributor

brianjlai commented Jan 6, 2023

What is the problem

Originally identified from work on another PR here: #20861 (comment)

From the substream slicer, we currently allow for developers to attempt to inject values into the request path. This is quite misleading because under the hood we don't actually do anything with the path because stream slicers don't have access to the path. They are built onto the retriever whereas path is managed by requesters. We should just throw an error if they attempt to do that. We have no existing connectors that try to do this

We are also incorrectly assigning the stream_state_value for the slices being created by the substream slicer.

todo add an example.

What is the desired solution

Throw errors when path is configured. We should be properly assigning to the correct key in the stream slice based on the parent stream config's request option (not the stream_state_value which is meant to indicate where to pull state data from a record)

Acceptance Criteria

  • An error should be thrown when a parent_stream_config's request_option, inject_into is set to path
  • During stream_slices(), the resulting slice should store the stream_state_value under a key based on the parent_stream_config.request_option.field_name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/extensibility type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant