Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Hubspot: schema should load properties dynamically #2219

Closed
eugene-kulak opened this issue Feb 26, 2021 · 1 comment
Closed

Source Hubspot: schema should load properties dynamically #2219

eugene-kulak opened this issue Feb 26, 2021 · 1 comment

Comments

@eugene-kulak
Copy link
Contributor

eugene-kulak commented Feb 26, 2021

Tell us about the problem you're trying to solve

Hubspot entities have dynamic schema, to retrieve a list of available (default and custom) properties we need to call
https://api.hubapi.com/properties/v2/ticket/properties?hapikey=demo (see StreamAPI.properties method).

Describe the solution you’d like

We should have a basic schema in schemas folder for each entity, retrieve properties at run time, merge it with basic and return during discover. Basically, we will reproduce logic in the singer tap (but will make it simpler).
Note: we need this only for entities, i.e. not for streams like contact_lists or data_pipelines

Describe the alternative you’ve considered or used

A clear and concise description of any alternative solutions or features you've considered or are using today.

Additional context

Add any other context or screenshots about the feature request here.

@keu
Copy link
Contributor

keu commented Mar 12, 2021

implemented as part of #2215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants