Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Github: if teams stream doesn't exist, don't fail sync because of it #2365

Closed
sherifnada opened this issue Mar 9, 2021 · 1 comment · Fixed by #2472
Closed

Source Github: if teams stream doesn't exist, don't fail sync because of it #2365

sherifnada opened this issue Mar 9, 2021 · 1 comment · Fixed by #2472
Assignees
@vitaliizazmic
Labels
area/connectors Connector related issues connectors/source/github connectors/sources-api type/bug Something isn't working
Milestone
Connectors April ...

Comments

@sherifnada
Copy link
Contributor

Expected Behavior

in cases like #2361 the Teams stream doesn't exist for the given repository. In this case, we shouldn't fail the whole sync. Instead, we should just sync no records and move along to the next stream, outputting a warning message. We should also document this in the github connector docs.

Severity of the bug for you

medium -- this is a recurring issue that users ask about
@sherifnada sherifnada added type/bug Something isn't working area/connectors Connector related issues labels Mar 9, 2021
@sherifnada sherifnada mentioned this issue Mar 9, 2021
Closed
@marcosmarxm
Copy link
Member

@sherifnada I saw this PR in singer-tap Github probably correcting this. It's a small change.

@sherifnada sherifnada mentioned this issue Mar 15, 2021
Closed
@sherifnada sherifnada added this to the Connectors 03-19-2021 milestone Mar 15, 2021
vitaliizazmic added a commit that referenced this issue Mar 15, 2021
@vitaliizazmic
Github #2365 - handling Teams streams syncing
2a9c85c
@vitaliizazmic vitaliizazmic mentioned this issue Mar 15, 2021
Merged
2 tasks
vitaliizazmic added a commit that referenced this issue Mar 30, 2021
@vitaliizazmic
Github Source #2365 - sync no records and show warning message if Col…
f5046a5 
…laborators Stream sync fails.
vitaliizazmic added a commit that referenced this issue Mar 30, 2021
@vitaliizazmic
Github Source #2365 - reformat
8544924
vitaliizazmic added a commit that referenced this issue Mar 30, 2021
@vitaliizazmic
Github Source #2365 - change fork to airbyte
1b3f4f2
vitaliizazmic added a commit that referenced this issue Mar 30, 2021
@vitaliizazmic
Github Source #2365 - Bump version
88328b5
vitaliizazmic added a commit that referenced this issue Mar 30, 2021
@vitaliizazmic @sherifnada
Source Github: Bugfix errors while syncing Team stream from non-organ…
dd26d2f 
…ization repo

* Github #2365 - handling Teams streams syncing

* Github Source #2365 - sync no records and show warning message if Collaborators Stream sync fails.

* Github Source #2365 - reformat

* Update docs/integrations/sources/github.md

* Update docs/integrations/sources/github.md

* Github Source #2365 - change fork to airbyte

* Github Source #2365 - Bump version

Co-authored-by: Sherif A. Nada <snadalive@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vitaliizazmic vitaliizazmic

Labels
area/connectors Connector related issues connectors/source/github connectors/sources-api type/bug Something isn't working
Projects
None yet
Milestone
Connectors April 2nd, 2021
4 participants
@marcosmarxm @sherifnada @vitaliizazmic @igrankova