-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-github
should support self-hosted Github instances
#24007
Comments
The person impleemnting this can take inspiration from source-gitlab, which supports users providing their own api_url. In the case of gitlab it's required (not sure if it should be actually), but it shouldn't be in the case of github - api.github.com should remain the default value if the user. doesn't provide one. |
I would like to work on this issue |
Also one small clarification on #24007 (comment) |
Please assign it to me @YowanR |
Assigning it to you @btkcodedev ! This should be a good one! 🚀 |
Allowed hosts live here and tell the airbyte server which hosts a connector should be allowed to access. You'll be adding something like |
Thanks for the quick response @evantahler 🚀 |
@YowanR PR raised and ready for review |
^ this is the PR #24095 |
Unassigning due to higher complexity than expected. |
@YowanR Would you be able to assign this issue to me? I opened PR #30076. cc: @btkcodedev |
Added as keywoard parameter to GitHubStream and Organizations. Also updated relevant functions in source.py. This enables functionality requested in issue airbytehq#24007.
Right now,
source-github
only connects toapi.github.com
. To support self-hosted instances, we should:api_url
which has a default value ofapi.github.com
(to make this change backwards compatible)."${api_url}"
to the connector's allowed_hostsThe text was updated successfully, but these errors were encountered: