Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-github should support self-hosted Github instances #24007

Closed
evantahler opened this issue Mar 13, 2023 · 11 comments · Fixed by #30647
Closed

source-github should support self-hosted Github instances #24007

evantahler opened this issue Mar 13, 2023 · 11 comments · Fixed by #30647
Assignees

Comments

@evantahler
Copy link
Contributor

evantahler commented Mar 13, 2023

Right now, source-github only connects to api.github.com. To support self-hosted instances, we should:

  • add an optional option to the connectors SPEC, api_url which has a default value of api.github.com (to make this change backwards compatible).
  • Update the code to use the new config option
  • Add "${api_url}" to the connector's allowed_hosts
@erohmensing
Copy link
Contributor

The person impleemnting this can take inspiration from source-gitlab, which supports users providing their own api_url. In the case of gitlab it's required (not sure if it should be actually), but it shouldn't be in the case of github - api.github.com should remain the default value if the user. doesn't provide one.

@btkcodedev
Copy link
Collaborator

I would like to work on this issue

@btkcodedev
Copy link
Collaborator

Also one small clarification on #24007 (comment)
Could you please specify where the allowed_hosts reside?

@btkcodedev
Copy link
Collaborator

Please assign it to me @YowanR

@YowanR
Copy link
Contributor

YowanR commented Mar 15, 2023

Assigning it to you @btkcodedev ! This should be a good one! 🚀

@evantahler
Copy link
Contributor Author

Also one small clarification on #24007 (comment) Could you please specify where the allowed_hosts reside?

Allowed hosts live here and tell the airbyte server which hosts a connector should be allowed to access. You'll be adding something like "${api_url}" which would pluck the value from the connector's configuration

@btkcodedev
Copy link
Collaborator

Thanks for the quick response @evantahler 🚀

@btkcodedev
Copy link
Collaborator

@YowanR PR raised and ready for review

@evantahler
Copy link
Contributor Author

^ this is the PR #24095

@marcosmarxm marcosmarxm added the contributor-program PRs submitted through the contributor program. label Apr 3, 2023
@btkcodedev
Copy link
Collaborator

Unassigning due to higher complexity than expected.
Community members are free to take this issue for assignment :)

@patkaehuaea
Copy link

patkaehuaea commented Sep 1, 2023

@YowanR Would you be able to assign this issue to me? I opened PR #30076. cc: @btkcodedev

patkaehuaea added a commit to patkaehuaea/airbyte that referenced this issue Sep 1, 2023
Added as keywoard parameter to GitHubStream and Organizations. Also
updated relevant functions in source.py. This enables functionality
requested in issue airbytehq#24007.
@artem1205 artem1205 self-assigned this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment