Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass control message to connector builder frontend #26909

Closed
2 tasks
maxi297 opened this issue Jun 1, 2023 · 3 comments
Closed
2 tasks

Pass control message to connector builder frontend #26909

maxi297 opened this issue Jun 1, 2023 · 3 comments
Assignees
Labels
area/connectors Connector related issues team/extensibility type/enhancement New feature or request

Comments

@maxi297
Copy link
Contributor

maxi297 commented Jun 1, 2023

What area the feature impact?

Connectors

Revelant Information

As a connector developer developing for single use refresh token API, I don't want to enter a new refresh token every time I do a test read

Context

Some APIs invalidate the refresh token once it's used (for example, quickbooks and GitLab). The platform and the CDK already have a mechanism to support this where a control message is emitted with the new configuration. We need to replicate this mechanism.

Gap

Today, the connector builder is silencing those messages. We need to return the latest one to the frontend so that it updates its config. In order to do that, we will:

  • Return the most recent AirbyteControlConnectorConfigMessage as part of the API
  • Frontend will use this information to update it's config

Acceptance criteria

  • A connector developer developing for single use refresh token API only needs to enter the refresh token once when opening the connector builder project. Do an example with an API
  • Disable testing values menu while request is in flight to avoid race condition
@flash1293
Copy link
Contributor

I'll move this back to the sprint backlog for now as it depends on the refresh token authenticator being available in the UI

maxi297 added a commit that referenced this issue Jun 5, 2023
maxi297 added a commit that referenced this issue Jun 7, 2023
#26922)

* [ISSUE #26909] add latest connector config control message to connector builder API

* [ISSUE #26909] flake

* Automated Commit - Formatting Changes

* [ISSUE #26909] fallback on in-memory dict if no config control message

* [ISSUE #26909] update and add tests
@flash1293
Copy link
Contributor

Needs a follow-up (owned by @maxi297 ) - to make sure the most recent config is captured in its entirety, we need a path in the code for components to queue messages for dispatching them later, see #27017

@flash1293 flash1293 removed their assignment Jun 8, 2023
@flash1293
Copy link
Contributor

Un-assigning myself for the next week

maxi297 added a commit that referenced this issue Jun 8, 2023
maxi297 added a commit that referenced this issue Jun 13, 2023
* [ISSUE #26909] adding message repository

* Automated Commit - Formatting Changes

* [ISSUE #26909] improve entrypoint error handling

* format CDK

* [ISSUE #26909] adding an integration test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues team/extensibility type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants