Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectors-ci: The Dagger UI url is not displayed in logs #27863

Closed
alafanechere opened this issue Jun 30, 2023 · 3 comments · Fixed by #28947
Closed

connectors-ci: The Dagger UI url is not displayed in logs #27863

alafanechere opened this issue Jun 30, 2023 · 3 comments · Fixed by #28947

Comments

@alafanechere
Copy link
Contributor

alafanechere commented Jun 30, 2023

All pipeline using dagger in our CI generate a Dagger Cloud run url that is helpful to debug pipeline execution and check what's cached or not.

This URL is only shared in the dagger logs that we persist at the end of the pipeline run to GCS.
It'd be great to get this url in the HTML report and in the GHA logs because it's helpful to track what's going on during pipeline execution.

We have two options to retrieve this url:

  • Hacky: Read the dagger logs at runtime in airbyte-ci and parse it when we find the log line "Dagger Cloud run url"
  • Ask the Dagger team if we can retrieve this url in a more elegant way with their SDK
@bnchrch
Copy link
Contributor

bnchrch commented Jul 25, 2023

grooming:

@bnchrch
Copy link
Contributor

bnchrch commented Jul 31, 2023

Grooming:

  1. We should only show this url when _EXPERIMENTAL_DAGGER_CLOUD_TOKEN
  2. We should only show this with --is-ci
  3. We should output this at the end in a very visually noticeable way that explicitly says in GHA logs, to debug go here

@alafanechere
Copy link
Contributor Author

alafanechere commented Jul 31, 2023

Definition of done:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants