airbyte-ci: add dagger run url #28947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octavia-squidington-iii
added
area/connectors
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
pedroslopez
commented
Aug 1, 2023
| @@ -169,6 +172,6 @@ | |||
| </div> | |||
| </div> | |||
| {% endfor %} | |||
| <p style="margin-top: 50px"><em>These reports are generated from <a href="https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connector_ops/connector_ops/pipelines/tests/templates/test_report.html.j2">this code</a>, please reach out to the Connector Operations team for support.</em></p> | |||
| <p style="margin-top: 50px"><em>These reports are generated from <a href="https://github.com/airbytehq/airbyte/blob/master/airbyte-ci/connectors/pipelines/pipelines/tests/templates/test_report.html.j2">this code</a>, please reach out to the Connector Operations team for support.</em></p> | |||
There was a problem hiding this comment.
This link was wrong after the move
Comment on lines
632
to
635
| console.print(main_panel) | ||
|
|
||
| if self.pipeline_context.dagger_cloud_url: | ||
| self.pipeline_context.logger.info(f"🔗 View commit in Dagger Cloud: {self.pipeline_context.dagger_cloud_url}") |
There was a problem hiding this comment.
Ideally i wanted to add this as a section in the Panel printed with console.print, but for the life of me I couldn't figure out how to make the link not get cut off. In CI it kept adding a newline which made the link not clickable.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
| Step | Result |
|---|---|
| Validate airbyte-integrations/connectors/source-faker/metadata.yaml | ✅ |
| Connector version semver check | ✅ |
| Connector version increment check | ❌ |
| QA checks | ✅ |
| Code format checks | ✅ |
| Connector package install | ✅ |
| Build source-faker docker image for platform linux/x86_64 | ✅ |
| Unit tests | ✅ |
| Acceptance tests | ✅ |
☁️ View commit in Dagger Cloud
Please note that tests are only run on PR ready for review. Please set your PR to draft mode to not flood the CI engine and upstream service on following commits.
You can run the same pipeline locally on this branch with the airbyte-ci tool with the following command
airbyte-ci connectors --name=source-faker test
pedroslopez
commented
Aug 1, 2023
| @@ -89,7 +89,7 @@ def check_dagger_cli_install() -> str: | |||
| def main(): | |||
| os.environ[DAGGER_CLOUD_TOKEN_ENV_VAR_NAME_VALUE[0]] = DAGGER_CLOUD_TOKEN_ENV_VAR_NAME_VALUE[1] | |||
| exit_code = 0 | |||
| if sys.argv[1] == "--no-tui": | |||
| if len(sys.argv) > 1 and sys.argv[1] == "--no-tui": | |||
There was a problem hiding this comment.
There was a bug with the latest changes here when no args were passed to airbyte-ci
bnchrch
approved these changes
Aug 1, 2023
| @@ -618,5 +628,8 @@ def print(self): | |||
| details_instructions = Text("ℹ️ You can find more details with step executions logs in the saved HTML report.") | |||
| to_render = [step_results_table, details_instructions] | |||
|
|
|||
| if self.pipeline_context.dagger_cloud_url: | |||
| self.pipeline_context.logger.info(f"🔗 View commit in Dagger Cloud: {self.pipeline_context.dagger_cloud_url}") | |||
There was a problem hiding this comment.
Suggested change
| self.pipeline_context.logger.info(f"🔗 View commit in Dagger Cloud: {self.pipeline_context.dagger_cloud_url}") | |
| self.pipeline_context.logger.info(f"🔗 For more information and better debugging view this run in Dagger Cloud: {self.pipeline_context.dagger_cloud_url}") |
alafanechere
approved these changes
Aug 2, 2023
| @@ -618,5 +628,8 @@ def print(self): | |||
| details_instructions = Text("ℹ️ You can find more details with step executions logs in the saved HTML report.") | |||
| to_render = [step_results_table, details_instructions] | |||
|
|
|||
| if self.pipeline_context.dagger_cloud_url: | |||
There was a problem hiding this comment.
Aren't you already logging this on line 481?
There was a problem hiding this comment.
This is a different Report's print. One is ConnectorReport.print and the other is Report.print
airbyte-ci/connectors/pipelines/pipelines/tests/templates/test_report.html.j2
Outdated
Show resolved
Hide resolved
…_report.html.j2 Co-authored-by: Augustin <augustin@airbyte.io>
Co-authored-by: Augustin <augustin@airbyte.io>
bnchrch
pushed a commit
that referenced
this pull request
Aug 3, 2023
* add dagger run url * version bump * making a change so tests are auto triggered * fix dagger cloud url * fix no args * naming / formatting * try nowrap * try soft_wrap * just log it * move log * revert fake change * rename * nits * Update airbyte-ci/connectors/pipelines/pipelines/tests/templates/test_report.html.j2 Co-authored-by: Augustin <augustin@airbyte.io> * Update airbyte-ci/connectors/pipelines/pipelines/contexts.py Co-authored-by: Augustin <augustin@airbyte.io> --------- Co-authored-by: Augustin <augustin@airbyte.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a link to the Dagger Cloud runs for the given commit when running in CI.
This is added to the reports as well as printed out to the console.
close #27863
How
Since we don't have a direct run ID, link to the Dagger Cloud changesByPipeline page, which lists all runs for a given commit.
Unfortunately this does mean that while the commit is the latest one on master, if anyone runs a publish or pre-release on master it will all get accumulated under that same page.
Examples