Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI should enforce setting cursor field on streams configured for incremental. #2950

Closed
cgardens opened this issue Apr 19, 2021 · 0 comments · Fixed by #3565
Closed

UI should enforce setting cursor field on streams configured for incremental. #2950

cgardens opened this issue Apr 19, 2021 · 0 comments · Fixed by #3565
Assignees
Labels
priority/high High priority type/bug Something isn't working

Comments

@cgardens
Copy link
Contributor

cgardens commented Apr 19, 2021

Expected Behavior

  • For incremental, when source_defined_cursor = false, the UI should force the user to set the cursor field.
  • For incremental, when source_defined_cursor = true, the UI should not let the user set a cursor field.

Current Behavior

  • Regardless of source_defined_cursor being true or false they can select a cursor field.
  • It is currently possible to configure an incremental sync with source_definied_cursor=false without setting a cursor field. we do now want this to be possible.

┆Issue is synchronized with this Asana task by Unito

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/high High priority type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants