Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schema object to connection schema validation #3565

Merged
merged 6 commits into from
Jun 1, 2021
Merged

Add schema object to connection schema validation #3565

merged 6 commits into from
Jun 1, 2021

Conversation

jamakase
Copy link
Contributor

@jamakase jamakase commented May 24, 2021 •
edited
Loading

What

Closes #2950
Closes #3182

How

Improve yup schema validation config:

  • Validate only selected entities
  • Validate selected cursor to be non-null for Incremental mode and when source_defined_cursor is false
  • Validate selected primaryKey to be non-null for Dedupted mode

Edit:

Also during merging figured out that we need some additional changes to show better errors. As a result made some improvements to performance

┆Issue is synchronized with this Asana task by Unito

@jamakase jamakase self-assigned this May 24, 2021
@jamakase jamakase marked this pull request as ready for review May 24, 2021 20:50
@auto-assign auto-assign bot requested review from cgardens and jrhizor May 24, 2021 20:50
@jamakase jamakase merged commit 494a9eb into master Jun 1, 2021
@jamakase jamakase deleted the jamakase/improve-connection-schema-validation branch June 1, 2021 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgardens cgardens cgardens approved these changes

@jrhizor jrhizor Awaiting requested review from jrhizor

Assignees

@jamakase jamakase

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jamakase @cgardens