Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAT: should validate the data types of output records #3253

Closed
sherifnada opened this issue May 5, 2021 · 1 comment · Fixed by #4345
Closed

SAT: should validate the data types of output records #3253

sherifnada opened this issue May 5, 2021 · 1 comment · Fixed by #4345
Assignees
@keu
Labels
Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# size/S type/enhancement New feature or request
Milestone
Connectors July 9...

Comments

@sherifnada
Copy link
Contributor

sherifnada commented May 5, 2021 •
edited by sync-by-unito bot

Tell us about the problem you're trying to solve

#3252 and #2927 are examples of problems that happened because the output data type does not match the type declared in the catalogt. We should update source acceptance tests so they assert the output data type matches the one declared in the catalog.

┆Issue is synchronized with this Asana task by Unito
@sherifnada sherifnada added type/enhancement New feature or request Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# labels May 5, 2021
@keu keu added this to the Connectors June 11, 2021 milestone May 28, 2021
@keu keu changed the title Standard tests should validate the data types of output records SAT: should validate the data types of output records May 28, 2021
@Zirochkaa
Copy link
Contributor

Zirochkaa commented Jun 15, 2021 •
edited by keu

  • run tests locally for any connector in order to understand how the running process works (build docker, install this test package, etc) (8h)
  • look through TestBasicRead and some examples of acceptance-test-config.yml files in order to decide where to add a new flag for type validation feature (3h)
  • add new function to ConnectorRunner if needed, depends on above step (1h)
  • came up with an idea about where to get schemas for streams (2h)
  • update TestBasicRead.test_read function with code that will do type validation (4h)
  • pick up any source and test this functionality on it (4h)

@keu keu assigned keu and unassigned Zirochkaa Jun 22, 2021
@keu keu linked a pull request Jun 25, 2021 that will close this issue
SAT: Add validation of data types in the output records #3253 #4345
Merged
@keu keu closed this as completed in #4345 Jul 5, 2021
keu added a commit that referenced this issue Jul 5, 2021
@keu @eugene-kulak @htrueman
SAT: Add validation of data types in the output records #3253 (#4345)
15c8f8a 
* validate that records match the schema from the catalog

Co-authored-by: Eugene Kulak <kulak.eugene@gmail.com>
Co-authored-by: Vadym <vege1wgw@gmail.com>
@sherifnada sherifnada mentioned this issue Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keu keu

Labels
Acceptance Tests https://docs.google.com/document/d/1pFLR8eLP5VOj6vDtWe69KZL0aWWHEA6Vkbod6NYJon4/edit# size/S type/enhancement New feature or request
Projects
None yet
Milestone
Connectors July 9, 2021
Development

Successfully merging a pull request may close this issue.

SAT: Add validation of data types in the output records #3253 airbytehq/airbyte
4 participants
@keu @sherifnada @Zirochkaa @VasylLazebnyk