Do not propagate all parameters to child nodes when using InlineSchemaLoader in low-code CDK

[ambirdsall]

Topic

No response

Relevant information

In this line, manifest_component_transformer.py propagates parameters in a way that is not valid for inline schemas; while this is not problem for manifests that are written to have inline schemas from the start (and thus, hopefully, don't use parameters to share schema data across multiple files), it is not a behavior that makes sense in this context and it complicates migrating an existing manifest to use inline schemas, which is a requirement for compatibility with the Connector Builder. Airbyte employees can reference this internal slack conversation for additional context.

[maxi297]

To add on the specific of source-activecampaign case, the issue is that there is a property named type which leads the propagation to continue as we don't hit this condition. The schema then ends up being modified like this (simplified version) which is not valid because properties.primary_key is expected to be an object

{
    "type": "object",
    "properties": {
        "type": {
            "type": "string",
            "name": "campaigns",
            "primary_key": "id",
            "$parameters": {
                "name": "campaigns",
                "primary_key": "id",
            }
        },
        "primary_key": "id",
        "$parameters": {
            "primary_key": "id",
            "name": "campaigns"
        }
    },
    "required": [
        "type"
    ]
}