-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[upgrade] Migrations from v0.44.2 are broken by the recent refactor #36855
Comments
My current workaround was to change the column type manually to make migrations pass: begin;
alter table connection alter column non_breaking_change_preference drop
not null;
alter table connection alter column non_breaking_change_preference drop
default;
alter table connection alter column non_breaking_change_preference TYPE
non_breaking_change_preference_type USING cast(non_breaking_change_preference as "non_breaking_change_preference_type");
alter table connection alter column non_breaking_change_preference set not null;
alter table connection alter column non_breaking_change_preference set default 'ignore'::non_breaking_change_preference_type;
commit; Make sure to revert the changes after the migration is done (I'm not sure this is the right way): begin;
alter table connection alter column non_breaking_change_preference drop
not null;
alter table connection alter column non_breaking_change_preference drop
default;
alter table connection alter column non_breaking_change_preference TYPE text;
alter table connection alter column non_breaking_change_preference set not null;
alter table connection alter column non_breaking_change_preference set default 'ignore';
commit; Update: typos fixed according to comments from @Dirkmal and @linuxs |
@killthekitten are you trying to migrate directly from 0.44 to latest? |
@marcosmarxm yes, that's correct, directly from 0.44 to latest! To be clear, we have already finished the migration using the workaround I posted above. |
I hit this as well. thanks for the workaround @killthekitten! I was able to create new connections without applying the workaround "undo", so I skipped that part |
@killthekitten I had the same issue when updating from 0.44.0 to latest. Solved it by updating to 0.51.0 first, then updating again to the latest version. |
@dcondePEAX nice workaround, it haven't crossed my mind. My thinking was that intermediate versions might introduce even more bugs, but good to know it worked! |
This workaround is a life-saver, I have spent the past 24 hours struggling to bring our airbyte up after updating. There is a small error in the last alter statement, see correction here: alter table connection alter column non_breaking_change_preference set default 'ignore'::non_breaking_change_preference_type; |
@Dirkmal thanks for the note, I edited my comment! I typed it out from memory looks like 😅 |
Is there a plan to fix the install script, so that users don't have to individually discover this issue and manually address? |
Correct code to undo is:
|
@linuxs edited again, thanks! |
Platform Version
0.44.0, 0.57.1
What step the error happened?
Upgrading the Platform or Helm Chart
Revelant information
We are upgrading from v0.44.0 to v0.57.1 and encountered an error in
V0_44_4_002__MigrateNonBreakingChangeToEnum
migration that stops the bootloader process:It comes from a typecast in migrateExistingDisableConnection. The migration was changed a few months ago in a mass refactor related to Micronaut, specifically this change:
airbytehq/airbyte-platform@75a3855#diff-65ad779d71239248181343fa5d51e662439bcf7b2b4ba2ea7073606210d5fb82R96-R98
The new code assumes that the column is of a type
non_breaking_change_preference_type
while it is actuallyvarchar
.FYI @jdpgrailsdev @jpefaur
Relevant log output
The text was updated successfully, but these errors were encountered: