-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for lookback window on incremental load - Stripe/All Sources #5765
Labels
area/connectors
Connector related issues
connectors/source/stripe
connectors/sources-api
type/enhancement
New feature or request
Milestone
Comments
thanks for the suggestion @JCWahoo ! Will make this available soon. I've updated the description to make it clearer what airbyte should do when supporting this. |
38 tasks
sherifnada
modified the milestones:
Connectors, September 17th 2021,
Connectors, October 1st 2021
Sep 17, 2021
@eliziario moving this out of the sprint for now |
Do we know when it might be worked on?
…On Fri, Sep 24, 2021, 1:33 AM Sherif A. Nada ***@***.***> wrote:
@eliziario <https://github.com/eliziario> moving this out of the sprint
for now
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5765 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUAW7TBP4D6J6Y3ZJHOO33TUDQEUDANCNFSM5DEYSIYQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
38 tasks
sherifnada
modified the milestones:
Connectors, October 1st 2021,
Connectors, October 15th 2021
Oct 4, 2021
@JCWahoo Added lookback_window_days parameter please update connector to 0.1.20 version |
@dmytro It doesnt appear I can save this setting, both save and retest are
not available
[image: image.png]
…On Tue, Oct 5, 2021 at 5:55 AM Dmytro ***@***.***> wrote:
@JCWahoo <https://github.com/JCWahoo> Added lookback_window_days
parameter please update connector to 0.1.20 version
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5765 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUAW7THGVGPFVC4UKJUBEXTUFLDRZANCNFSM5DEYSIYQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
connectors/source/stripe
connectors/sources-api
type/enhancement
New feature or request
Tell us about the problem you're trying to solve
I'm attempting to replace my existing Stitch(Singer) Stripe integration w/ Airbyte. I've run into a few scenarios where updates are arriving late to existing objects (charges, invoices, subscriptions). Due to this, I must use a full refresh rather than incremental load for those streams
Describe the solution you’d like
In reviewing the Singer spec, their connection is using a 30 day lookback window for incremental load. I'd like the ability to set this lookback window as part of any incremental source, but specifically Stripe for this use case. Rather than requesting records where >= last_cursor, I'd like to retrieve where >= last_cursor - {my prescribed interval in days})
Describe the alternative you’ve considered or used
I'm currently using Stitch :-)
Additional context
By either adding this default lookback or allowing the user to choose, we're meeting/exceeding the capabilities of our competitors
Are you willing to submit a PR?
This is one where I feel like it sounds easy enough to add the lookback, though I suspect this cursor implementation has further ramifications depending on source
Acceptance Criteria
lookback_window_days
to the stripe connector which causes the connector . This option should default to 0. The option should also be annotated withadvanced=true
for when there is a separate advanced options section in the UI.The text was updated successfully, but these errors were encountered: