Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for lookback window on incremental load - Stripe/All Sources #5765

Closed
JCWahoo opened this issue Aug 31, 2021 · 6 comments · Fixed by #6017
Closed

Allow for lookback window on incremental load - Stripe/All Sources #5765

JCWahoo opened this issue Aug 31, 2021 · 6 comments · Fixed by #6017

Comments

@JCWahoo
Copy link

JCWahoo commented Aug 31, 2021

Tell us about the problem you're trying to solve

I'm attempting to replace my existing Stitch(Singer) Stripe integration w/ Airbyte. I've run into a few scenarios where updates are arriving late to existing objects (charges, invoices, subscriptions). Due to this, I must use a full refresh rather than incremental load for those streams

Describe the solution you’d like

In reviewing the Singer spec, their connection is using a 30 day lookback window for incremental load. I'd like the ability to set this lookback window as part of any incremental source, but specifically Stripe for this use case. Rather than requesting records where >= last_cursor, I'd like to retrieve where >= last_cursor - {my prescribed interval in days})

Describe the alternative you’ve considered or used

I'm currently using Stitch :-)

Additional context

By either adding this default lookback or allowing the user to choose, we're meeting/exceeding the capabilities of our competitors

Are you willing to submit a PR?

This is one where I feel like it sounds easy enough to add the lookback, though I suspect this cursor implementation has further ramifications depending on source

Acceptance Criteria

  1. Add an optional integer input lookback_window_days to the stripe connector which causes the connector . This option should default to 0. The option should also be annotated with advanced=true for when there is a separate advanced options section in the UI.
@JCWahoo JCWahoo added the type/enhancement New feature or request label Aug 31, 2021
@sherifnada
Copy link
Contributor

thanks for the suggestion @JCWahoo ! Will make this available soon. I've updated the description to make it clearer what airbyte should do when supporting this.

@eliziario
Copy link
Contributor

eliziario commented Sep 14, 2021

/publish-cdk dry-run=false

https://github.com/airbytehq/airbyte/actions/runs/1234013232
https://github.com/airbytehq/airbyte/actions/runs/1234013232
https://github.com/airbytehq/airbyte/actions/runs/1234013232
https://github.com/airbytehq/airbyte/actions/runs/1234013232

@sherifnada
Copy link
Contributor

@eliziario moving this out of the sprint for now

@JCWahoo
Copy link
Author

JCWahoo commented Sep 24, 2021 via email

@avida
Copy link
Contributor

avida commented Oct 5, 2021

@JCWahoo Added lookback_window_days parameter please update connector to 0.1.20 version

@JCWahoo
Copy link
Author

JCWahoo commented Oct 5, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants