Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trello: support oauth for source connector and airbyte server #6297

Closed
sherifnada opened this issue Sep 20, 2021 · 1 comment · Fixed by #6944 or #6968
Closed

Trello: support oauth for source connector and airbyte server #6297

sherifnada opened this issue Sep 20, 2021 · 1 comment · Fixed by #6944 or #6968

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Sep 20, 2021

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.

Acceptance Criteria

  1. The connector supports oauth webflow authentication with client_id/client_secret
  2. Oauth properties are annotated properly. See this PR for an example
  3. Airbyte server supports for trello authentication
@sherifnada sherifnada added area/oauth area/connectors Connector related issues labels Sep 20, 2021
@avida avida self-assigned this Oct 4, 2021
@avida
Copy link
Contributor

avida commented Oct 4, 2021

Oauth 1.0a only.
https://developer.atlassian.com/cloud/trello/guides/rest-api/authorization/#using-basic-oauth
Connector already works with key and token which is enough for oauth authorization, need only update spec file but its Oauth 1.0. Not sure we have implemented it.

@avida avida changed the title Source Trello: support oauth Trello: support oauth for source connector and airbyte server Oct 7, 2021
@avida avida mentioned this issue Oct 11, 2021
38 tasks
@avida avida linked a pull request Oct 11, 2021 that will close this issue
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants