Trello source: Add oAuth flow #6968

avida · 2021-10-12T09:24:18Z

What

Resolves #6297

How

Describe the solution

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Updating a connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
Credentials added to Github CI. Instructions.
/test connector=connectors/<name> command is passing.
New Connector version released on Dockerhub by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed.

avida · 2021-10-12T09:25:02Z

/test connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1332466527
✅ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1332466527
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_trello/__init__.py       2      0   100%
	 source_trello/source.py       107     32    70%
	 source_trello/utils.py         28     13    54%
	 -----------------------------------------------
	 TOTAL                         137     45    67%

avida · 2021-10-12T11:11:47Z

/test connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1332821802
✅ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1332821802
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_trello/__init__.py       2      0   100%
	 source_trello/source.py       107     32    70%
	 source_trello/utils.py         28     13    54%
	 -----------------------------------------------
	 TOTAL                         137     45    67%

sherifnada

I'm not sure this change is necessary -- if none of the inputs are changing then what is the motivation for changing the config?

airbyte-integrations/connectors/source-trello/source_trello/spec.json

avida · 2021-10-13T07:31:51Z

@jamakase I've made small UI change in this PR https://github.com/airbytehq/airbyte/pull/6968/files#diff-393e26e4c3c078643dfe0849b9212c86e0b5e52aed0f4b74a93f0c309312095cR143 could you take a look on it ?

avida · 2021-10-13T08:15:41Z

Ive set "additionalProperties" to true cause of this #5989 issue airbyte server would add secret_id and secret_config in config even if its not specified in oauth flow

avida · 2021-10-13T08:39:35Z

/test connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1336657594
✅ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1336657594
Python tests coverage:

	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                                 Stmts   Miss  Cover
	 ------------------------------------------------------------------------
	 source_acceptance_test/__init__.py                       2      0   100%
	 source_acceptance_test/base.py                          10      4    60%
	 source_acceptance_test/config.py                        74      8    89%
	 source_acceptance_test/conftest.py                     108    108     0%
	 source_acceptance_test/plugin.py                        47     47     0%
	 source_acceptance_test/tests/__init__.py                 4      0   100%
	 source_acceptance_test/tests/test_core.py              200     94    53%
	 source_acceptance_test/tests/test_full_refresh.py       18     11    39%
	 source_acceptance_test/tests/test_incremental.py        69     38    45%
	 source_acceptance_test/utils/__init__.py                 6      0   100%
	 source_acceptance_test/utils/asserts.py                 37      2    95%
	 source_acceptance_test/utils/common.py                  41     24    41%
	 source_acceptance_test/utils/compare.py                 47     20    57%
	 source_acceptance_test/utils/connector_runner.py        82     49    40%
	 source_acceptance_test/utils/json_schema_helper.py     115     14    88%
	 ------------------------------------------------------------------------
	 TOTAL                                                  860    419    51%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                                       Stmts   Miss  Cover
	 --------------------------------------------------------------
	 base_python/__init__.py                       13      0   100%
	 base_python/catalog_helpers.py                10      6    40%
	 base_python/cdk/__init__.py                    0      0   100%
	 base_python/cdk/abstract_source.py            83     59    29%
	 base_python/cdk/streams/__init__.py            0      0   100%
	 base_python/cdk/streams/auth/__init__.py       0      0   100%
	 base_python/cdk/streams/auth/core.py           8      1    88%
	 base_python/cdk/streams/auth/jwt.py            5      5     0%
	 base_python/cdk/streams/auth/oauth.py         37     26    30%
	 base_python/cdk/streams/auth/token.py          9      4    56%
	 base_python/cdk/streams/core.py               63     32    49%
	 base_python/cdk/streams/exceptions.py         10      2    80%
	 base_python/cdk/streams/http.py               67     33    51%
	 base_python/cdk/streams/rate_limiting.py      30     14    53%
	 base_python/cdk/utils/__init__.py              0      0   100%
	 base_python/cdk/utils/casing.py                4      0   100%
	 base_python/client.py                         56     33    41%
	 base_python/entrypoint.py                     70     56    20%
	 base_python/integration.py                    52     25    52%
	 base_python/logger.py                         33     19    42%
	 base_python/schema_helpers.py                 56     41    27%
	 base_python/source.py                         51     34    33%
	 main_dev.py                                    3      3     0%
	 --------------------------------------------------------------
	 TOTAL                                        660    393    40%
	 ---------- coverage: platform linux, python 3.8.10-final-0 -----------
	 Name                        Stmts   Miss  Cover
	 -----------------------------------------------
	 source_trello/__init__.py       2      0   100%
	 source_trello/source.py       105     31    70%
	 source_trello/utils.py         28     13    54%
	 -----------------------------------------------
	 TOTAL                         135     44    67%

avida · 2021-10-14T06:28:34Z

/publish connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1340613502
✅ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1340613502

avida · 2021-10-14T06:28:54Z

/publish connector=connectors/source-trello

🕑 connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1340614275
✅ connectors/source-trello https://github.com/airbytehq/airbyte/actions/runs/1340614275

github-actions bot added the area/connectors Connector related issues label Oct 12, 2021

avida temporarily deployed to more-secrets October 12, 2021 09:25 Inactive

avida force-pushed the drezchykov/trello-oauth branch from 12f17c8 to 2b2f41b Compare October 12, 2021 09:26

github-actions bot added the area/documentation Improvements or additions to documentation label Oct 12, 2021

avida temporarily deployed to more-secrets October 12, 2021 09:28 Inactive

avida requested review from htrueman, yevhenii-ldv and Zirochkaa October 12, 2021 09:55

avida force-pushed the drezchykov/trello-oauth branch from 2b2f41b to 2c67c31 Compare October 12, 2021 11:11

avida temporarily deployed to more-secrets October 12, 2021 11:13 Inactive

jrhizor temporarily deployed to more-secrets October 12, 2021 11:13 Inactive

Zirochkaa approved these changes Oct 12, 2021

View reviewed changes

avida requested a review from sherifnada October 13, 2021 06:40

Trello source: Add oAuth flow.

d124a2f

avida force-pushed the drezchykov/trello-oauth branch from 2c67c31 to d124a2f Compare October 13, 2021 06:57

avida temporarily deployed to more-secrets October 13, 2021 06:59 Inactive

sherifnada reviewed Oct 13, 2021

View reviewed changes

airbyte-integrations/connectors/source-trello/source_trello/spec.json Outdated Show resolved Hide resolved

github-actions bot added the area/frontend label Oct 13, 2021

avida temporarily deployed to more-secrets October 13, 2021 07:21 Inactive

Fix UI defect for oauth 1.0

11aaebd

avida force-pushed the drezchykov/trello-oauth branch from c72e293 to 11aaebd Compare October 13, 2021 07:29

avida temporarily deployed to more-secrets October 13, 2021 07:30 Inactive

avida requested a review from jamakase October 13, 2021 07:31

Fix review comments

93965a5

avida requested a review from sherifnada October 13, 2021 08:14

avida temporarily deployed to more-secrets October 13, 2021 08:15 Inactive

jrhizor temporarily deployed to more-secrets October 13, 2021 08:42 Inactive

jamakase approved these changes Oct 13, 2021

View reviewed changes

sherifnada approved these changes Oct 13, 2021

View reviewed changes

jrhizor temporarily deployed to more-secrets October 14, 2021 06:30 Inactive

avida merged commit 2e7ff2e into master Oct 14, 2021

avida deleted the drezchykov/trello-oauth branch October 14, 2021 06:46

jrhizor mentioned this pull request Oct 19, 2021

Bump Airbyte version from 0.30.20-alpha to 0.30.21-alpha #7145

Merged

schlattk pushed a commit to schlattk/airbyte that referenced this pull request Jan 4, 2022

Trello source: Add oAuth flow (airbytehq#6968)

3155994

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Trello source: Add oAuth flow #6968

Trello source: Add oAuth flow #6968

avida commented Oct 12, 2021

avida commented Oct 12, 2021 •

edited by github-actions bot

Loading

avida commented Oct 12, 2021 •

edited by github-actions bot

Loading

sherifnada left a comment •

edited

Loading

avida commented Oct 13, 2021

avida commented Oct 13, 2021

avida commented Oct 13, 2021 •

edited by github-actions bot

Loading

avida commented Oct 14, 2021 •

edited by github-actions bot

Loading

avida commented Oct 14, 2021 •

edited by github-actions bot

Loading

Trello source: Add oAuth flow #6968

Trello source: Add oAuth flow #6968

Conversation

avida commented Oct 12, 2021

What

How

Recommended reading order

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

avida commented Oct 12, 2021 • edited by github-actions bot Loading

avida commented Oct 12, 2021 • edited by github-actions bot Loading

sherifnada left a comment • edited Loading

Choose a reason for hiding this comment

avida commented Oct 13, 2021

avida commented Oct 13, 2021

avida commented Oct 13, 2021 • edited by github-actions bot Loading

avida commented Oct 14, 2021 • edited by github-actions bot Loading

avida commented Oct 14, 2021 • edited by github-actions bot Loading

avida commented Oct 12, 2021 •

edited by github-actions bot

Loading

avida commented Oct 12, 2021 •

edited by github-actions bot

Loading

sherifnada left a comment •

edited

Loading

avida commented Oct 13, 2021 •

edited by github-actions bot

Loading

avida commented Oct 14, 2021 •

edited by github-actions bot

Loading

avida commented Oct 14, 2021 •

edited by github-actions bot

Loading