Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stripe Source check succeeds even when credentials are invalid #663

Closed
cgardens opened this issue Oct 20, 2020 · 1 comment · Fixed by #1769
Closed

Stripe Source check succeeds even when credentials are invalid #663

cgardens opened this issue Oct 20, 2020 · 1 comment · Fixed by #1769
Assignees
@yevhenii-ldv
Labels
connectors/source/stripe connectors/sources-api type/bug Something isn't working
Milestone
Beta Launch

Comments

@cgardens
Copy link
Contributor

Returns success even if the wrong key is provided.
@cgardens cgardens added the type/bug Something isn't working label Oct 20, 2020
@cgardens cgardens added this to the v0.3.0 milestone Oct 20, 2020
@cgardens cgardens removed this from the v0.3.0 milestone Nov 12, 2020
@cgardens cgardens added this to the Launch 1.0 milestone Jan 19, 2021
@sherifnada
Copy link
Contributor

this issue happens when account_id is incorrect. Assigning to @yevhenii-ldv

yevhenii-ldv added a commit that referenced this issue Jan 21, 2021
@yevhenii-ldv
#663 Issue: fix check connecting for Stripe Source
bd7fbec
@sherifnada sherifnada linked a pull request Jan 21, 2021 that will close this issue
#663 Issue: fix check connecting for Stripe Source #1769
Merged
2 tasks
sherifnada added a commit that referenced this issue Jan 22, 2021
@yevhenii-ldv @sherifnada
#663 Issue: fix check connecting for Stripe Source (#1769)
08a4285 
Co-authored-by: Sherif Nada <snadalive@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yevhenii-ldv yevhenii-ldv

Labels
connectors/source/stripe connectors/sources-api type/bug Something isn't working
Projects
None yet
Milestone
Beta Launch
Development

Successfully merging a pull request may close this issue.

#663 Issue: fix check connecting for Stripe Source airbytehq/airbyte
4 participants
@sherifnada @cgardens @yevhenii-ldv @igrankova