Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to depend on python airbyte protocol generated structs without running entrypoint. #718

Closed
cgardens opened this issue Oct 27, 2020 · 1 comment
Closed

Make it possible to depend on python airbyte protocol generated structs without running entrypoint. #718

cgardens opened this issue Oct 27, 2020 · 1 comment
Assignees
@cgardens
Labels
type/enhancement New feature or request
Milestone
v0.4.0

Comments

@cgardens
Copy link
Contributor

cgardens commented Oct 27, 2020 •
edited

This line ends up running env specific code (specifically this) when trying to access the aribyte_protocol module. This is bad because in this case we are just trying to get access to the generated structs and don't want to deal with any of these env specific side effects (causing this hack). Probably should just split the structs into their own module.
@cgardens cgardens added the type/enhancement New feature or request label Oct 27, 2020
@cgardens cgardens self-assigned this Oct 28, 2020
@cgardens cgardens mentioned this issue Oct 28, 2020
Merged
@cgardens cgardens added this to the v0.4.0 milestone Oct 28, 2020
@cgardens
Copy link
Contributor Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgardens cgardens

Labels
type/enhancement New feature or request
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
1 participant
@cgardens