split airbyte protocol generated structs out of base_python #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
requested review from
jrhizor,
michel-tricot,
sherifnada and
ChristopheDuong
cgardens
force-pushed
the
cgardens/split_out_structs
branch
from
b7bb6a4
to
f046e2b
Compare
cgardens
changed the base branch from
cgardens/python_to_standard_test
to
master
cgardens
commented
Oct 28, 2020
| @@ -1 +0,0 @@ | |||
| ../../bases/base-singer/base_singer | |||
There was a problem hiding this comment.
@jrhizor i ended up deleting a ton of these symlinks. do you know why these were here? or did they just sneak in?
There was a problem hiding this comment.
It was on purpose for DX: #716 (comment)
cgardens
commented
Oct 28, 2020
| @@ -31,7 +31,7 @@ | |||
| author_email="contact@airbyte.io", | |||
| url="https://github.com/airbytehq/airbyte", | |||
| packages=setuptools.find_packages(), | |||
| install_requires=["airbyte_protocol"], | |||
| install_requires=["airbyte-protocol"], | |||
There was a problem hiding this comment.
apparently python will accept either of these.... _ or -. normalizing to - as i think it should be referring to the package name.
ChristopheDuong
approved these changes
Oct 28, 2020
jrhizor
approved these changes
Oct 28, 2020
| @@ -0,0 +1 @@ | |||
| airbyte_protocol/models/yaml | |||
There was a problem hiding this comment.
There isn't anything in this location. This .gitignore file can be deleted.
| SOFTWARE. | ||
| """ | ||
|
|
||
| from airbyte_protocol.entrypoint import main |
There was a problem hiding this comment.
This is in the base, not airbyte-protocol? Can we just delete this file? I don't think we need it for a library class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
airbyte-protocol- lib with structsbase-python- the base python stuffdependsOnright in gradle for the python modules. in some cases we were missingdependsOnstatements leading to non-deterministic behavior. honestly not sure that i got them all yet.