Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API doesn't fail on incorrect params are passed. #99

Closed
cgardens opened this issue Aug 24, 2020 · 1 comment
Closed

API doesn't fail on incorrect params are passed. #99

cgardens opened this issue Aug 24, 2020 · 1 comment
Assignees
@cgardens
Labels
type/bug Something isn't working

Comments

@cgardens
Copy link
Contributor

Expected Behavior

  • the API should throw an exception when it receives a request body for a route that does not match what is defined in swagger.

Current Behavior

  • the API just tries to process the incomplete body.

Steps to Reproduce

  1. curl -H "Content-Type: application/json" -X POST localhost:8001/api/v1/workspaces/update -d '{ "anonymousDataCollection": false, "email": "jamakase54+10@gmail.com", "news": false, "securityUpdates": true, "workspaceId": "5ae6b09b-fdec-41af-aaf7-7d94cfc33ef6" }' note: initialSetupComplete field is missing.
@cgardens cgardens added the type/bug Something isn't working label Aug 24, 2020
@cgardens cgardens self-assigned this Sep 9, 2020
@cgardens
Copy link
Contributor Author

cgardens commented Sep 9, 2020

closed by #104

@cgardens cgardens closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgardens cgardens

Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cgardens