validate request body against openapi schema #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgardens
commented
Aug 25, 2020
| @Provider | ||
| public class InvalidInputExceptionMapper implements ExceptionMapper<JsonMappingException> { | ||
| public class InvalidInputExceptionMapper implements ExceptionMapper<ConstraintViolationException> { |
There was a problem hiding this comment.
essentially i took the original class of this name and moved it to InvalidJsonInputExceptionMapper.java. the original class is handling exceptions that arise in the jackson json parsing layers.
this new class is handling errors for when the request body does not match the described open api spec.
michel-tricot
approved these changes
Aug 25, 2020
| .put("message", "The received object did not pass validation") | ||
| .put("details", e.getOriginalMessage()) | ||
| .toString()) | ||
| .put("message", "Invalid JSON") |
There was a problem hiding this comment.
I this the right message?
There was a problem hiding this comment.
shoudln't it be "The received object did not pass validation"?
| .entity( | ||
| new ObjectMapper() | ||
| .createObjectNode() | ||
| .put("message", "The received object did not pass validation") |
There was a problem hiding this comment.
Shouldn't it be Invalid JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The API was not actually validating that the incoming request body matched the schema described in our open api config.
How
jersey-bean-validation.