Add release_stage and release_date to ActorDefinition table #10051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api
pmossman
changed the base branch from
master
to
parker/set_tombstone_field_in_persistence
jrhizor
approved these changes
Feb 4, 2022
airbyte-config/models/src/main/resources/types/StandardDestinationDefinition.yaml
Show resolved
Hide resolved
airbyte-config/models/src/main/resources/types/StandardSourceDefinition.yaml
Show resolved
Hide resolved
| : Enums.toEnum(standardSourceDefinition.getReleaseStage().value(), | ||
| io.airbyte.db.instance.configs.jooq.enums.ReleaseStage.class).orElseThrow()) | ||
| .set(ACTOR_DEFINITION.RELEASE_DATE, standardSourceDefinition.getReleaseDate() == null ? null | ||
| : LocalDate.parse(standardSourceDefinition.getReleaseDate().toString())) // TODO make sure this works |
| : Enums.toEnum(standardSourceDefinition.getReleaseStage().value(), | ||
| io.airbyte.db.instance.configs.jooq.enums.ReleaseStage.class).orElseThrow()) | ||
| .set(ACTOR_DEFINITION.RELEASE_DATE, standardSourceDefinition.getReleaseDate() == null ? null | ||
| : LocalDate.parse(standardSourceDefinition.getReleaseDate().toString())) // TODO make sure this works |
pmossman
force-pushed
the
parker/set_tombstone_field_in_persistence
branch
from
eed18bb
to
597a7d6
Compare
Base automatically changed from
parker/set_tombstone_field_in_persistence
to
master
February 4, 2022 19:54
- migration to add columns - update json schema to add new fields - update API schema to include new fields in definition reads - update tests
pmossman
force-pushed
the
parker/add-release-stage-to-connector-definition
branch
from
9c44768
to
a556599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Issue: #9711
Internal slack conversation with some more context: https://airbytehq-team.slack.com/archives/C02TL38U5L7/p1643247936054200
We want to mark connectors with different release stages (Alpha, Beta, Custom, Generally Available), and eventually want to mark new connectors with a 'New' badge.
This PR introduces
release_dateandrelease_stageas optional columns/fields on our connector definition table/schemas.How
create*Definitionhandler methods tocreateCustom*Definitionbecause we now assume that any definition created via API should be marked withcustomrelease_stageSide note: I have another PR that adds a 'tombstone' column to actor_definition. Subodh informed me about upgrading the
CONFIGS_DATABASE_MINIMUM_FLYWAY_MIGRATION_VERSIONfor cloud releases, so I will be sure to handle that for both of my PRs that introduce new columns. (I will bundle these two PRs as a single release and then release them to Cloud together).Recommended reading order
馃毃 User Impact 馃毃
No user impact yet, this just introduces the columns and fields that will later be populated with release stage/date information through our connector seeds.