Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉 Updated timestamp transformation with microseconds #10242

Merged
merged 24 commits into from
Feb 18, 2022
Merged

🎉 Updated timestamp transformation with microseconds #10242

merged 24 commits into from
Feb 18, 2022

Conversation

andriikorotkov
Copy link
Contributor

@andriikorotkov andriikorotkov commented Feb 10, 2022 •
edited
Loading

What

Describe what the change is solving
It helps to add screenshots if it affects the frontend.

How

2022-02-17_10-48

2022-02-17_10-49

2022-02-17_10-50

2022-02-17_10-51

Recommended reading order

  1. DataTypeUtils.java
  2. AbstractJdbcCompatibleSourceOperations.java
  3. DebeziumConverterUtils.java
  4. JdbcSourceAcceptanceTest.java

🚨 User Impact 🚨

Time-related fields that are used for incremental sync will have better precision.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the connector is published, connector added to connector index as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • Credentials added to Github CI. Instructions.
  • /test connector=connectors/<name> command is passing.
  • New Connector version released on Dockerhub by running the /publish command described here
  • After the new connector version is published, connector version bumped in the seed directory as described here
  • Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Connector Generator

  • Issue acceptance criteria met
  • PR name follows PR naming conventions
  • If adding a new generator, add it to the list of scaffold modules being tested
  • The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
  • Documentation which references the generator is updated as needed.

@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 10, 2022 15:51 Inactive
@github-actions github-actions bot added the area/connectors Connector related issues label Feb 10, 2022
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 10, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1824729089
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1824729089
No Python unittests run

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 10, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1824729971
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1824729971
🐛 https://gradle.com/s/ev5rlz2a3qnge

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 10, 2022 15:55 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 10, 2022 15:55 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 11, 2022 07:57 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 11, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1828241215
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1828241215
🐛 https://gradle.com/s/wrzr34unp2soe

@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 11, 2022 08:11 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 11, 2022 08:12 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 11, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1828433091
❌ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1828433091
🐛 https://gradle.com/s/3prmrix24f4ic

@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 11, 2022 09:02 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 11, 2022 09:04 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 11, 2022 09:46 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 11, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1828760975
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1828760975
No Python unittests run

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 11, 2022 10:23 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 11, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1828867849
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/1828867849
No Python unittests run

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 11, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-oracle

🕑 connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1828868908
❌ connectors/source-oracle https://github.com/airbytehq/airbyte/actions/runs/1828868908
🐛 https://gradle.com/s/lymajsa4oqmtg

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 11, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-snowflake

🕑 connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1828869384
✅ connectors/source-snowflake https://github.com/airbytehq/airbyte/actions/runs/1828869384
No Python unittests run

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 11, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-db2

🕑 connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1828869898
✅ connectors/source-db2 https://github.com/airbytehq/airbyte/actions/runs/1828869898
No Python unittests run

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 09:47 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 09:48 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 09:48 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 18, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-oracle-strict-encrypt

🕑 connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863909032
❌ connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863909032

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 18, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-cockroachdb-strict-encrypt

🕑 connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863911495
✅ connectors/source-cockroachdb-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863911495

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 18, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-db2-strict-encrypt

🕑 connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863914665
✅ connectors/source-db2-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863914665

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 18, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863916239
✅ connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863916239

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 18, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-mysql-strict-encrypt

🕑 connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863918863
✅ connectors/source-mysql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863918863

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 18, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863920299
❌ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1863920299

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 10:39 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 10:39 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 10:40 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 10:40 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 10:41 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 10:41 Inactive
@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 18, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-postgres-strict-encrypt

🕑 connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1864296828
✅ connectors/source-postgres-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1864296828

@andriikorotkov
Copy link
Contributor Author

andriikorotkov commented Feb 18, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-oracle-strict-encrypt

🕑 connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1864297832
✅ connectors/source-oracle-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1864297832

@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 18, 2022 12:11 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 18, 2022 12:11 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 12:12 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 18, 2022 12:12 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 18, 2022 12:38 Inactive
@andriikorotkov andriikorotkov temporarily deployed to more-secrets February 18, 2022 12:39 Inactive
@andriikorotkov andriikorotkov merged commit 9d401fc into master Feb 18, 2022
@andriikorotkov andriikorotkov deleted the akorotkov/9963-postgres-timestamp branch February 18, 2022 12:52
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 18, 2022
Merged
@tuliren
Copy link
Contributor

tuliren commented Feb 18, 2022

By the way, one test case in DebeziumConverterUtilsTest.java needs to be updated as well. It's fixed in #10468.

It's understandable that the format step in CI failed due to an issue that was not related to this PR, which prevented the tests from running automatically. But when that happens, we should still make sure the tests can pass at least locally.

@andriikorotkov
Copy link
Contributor Author

@tuliren thank you. This is my mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

@alexandr-shegeda alexandr-shegeda alexandr-shegeda approved these changes

@mkhokh-33 mkhokh-33 mkhokh-33 approved these changes

@VitaliiMaltsev VitaliiMaltsev Awaiting requested review from VitaliiMaltsev

@tuliren tuliren Awaiting requested review from tuliren

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
6 participants
@andriikorotkov @tuliren @edgao @alexandr-shegeda @mkhokh-33 @octavia-squidington-iii