Add ExitOnOutOfMemoryError to java connectors and bump versions #10256

lmossman · 2022-02-11T00:19:07Z

See context here: https://airbytehq-team.slack.com/archives/C02U46QK5C3/p1644534663479069?thread_ts=1644532106.854279&cid=C02U46QK5C3

We have connectors that are hanging due to the java thread throwing an OutOfMemoryError, but the pod not actually failing. Adding this flag will cause the process to exit, correctly closing the pod and surfacing the OOM issue faster.

…nnectors

lmossman · 2022-02-11T00:23:18Z

/test connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1826882767
✅ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1826882767
No Python unittests run

lmossman · 2022-02-11T00:23:34Z

/test connector=connectors/destination-gcs

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1826883299
❌ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1826883299
🐛

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1826883299
❌ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1826883299
🐛

lmossman · 2022-02-11T00:24:11Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1826886192
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/1826886192
No Python unittests run

edgao

not sure why the gcs test failed. will try to repro locally, but I don't think it blocks this PR

cgardens

Clutch!

Seeing the scope of this PR makes it feel like we should figure out how to inherit these JVM options across connectors! Definitely not a right now thing. Just an observation.

lmossman · 2022-02-11T01:09:02Z

@cgardens there is sort of an existing issue to take care of that, which was created when we added the max RAM percentage flag originally: https://github.com/airbytehq/airbyte-internal-issues/issues/264

lmossman · 2022-02-11T01:10:50Z

/publish connector=connectors/destination-azure-blob-storage

🕑 connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1827039338
✅ connectors/destination-azure-blob-storage https://github.com/airbytehq/airbyte/actions/runs/1827039338

lmossman · 2022-02-11T01:11:26Z

/publish connector=connectors/destination-bigquery-denormalized

🕑 connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1827041552
❌ connectors/destination-bigquery-denormalized https://github.com/airbytehq/airbyte/actions/runs/1827041552

lmossman · 2022-02-11T01:11:47Z

/publish connector=connectors/destination-bigquery

🕑 connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1827042314
❌ connectors/destination-bigquery https://github.com/airbytehq/airbyte/actions/runs/1827042314

lmossman · 2022-02-11T01:12:01Z

/publish connector=connectors/destination-cassandra

🕑 connectors/destination-cassandra https://github.com/airbytehq/airbyte/actions/runs/1827043201
✅ connectors/destination-cassandra https://github.com/airbytehq/airbyte/actions/runs/1827043201

lmossman · 2022-02-11T01:12:16Z

/publish connector=connectors/destination-clickhouse-strict-encrypt

🕑 connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1827043841
❌ connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1827043841
🕑 connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1827043841
❌ connectors/destination-clickhouse-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/1827043841

lmossman · 2022-02-11T01:12:26Z

/publish connector=connectors/destination-clickhouse

🕑 connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1827044579
✅ connectors/destination-clickhouse https://github.com/airbytehq/airbyte/actions/runs/1827044579

lmossman · 2022-02-11T01:12:33Z

/publish connector=connectors/destination-csv

🕑 connectors/destination-csv https://github.com/airbytehq/airbyte/actions/runs/1827045073
✅ connectors/destination-csv https://github.com/airbytehq/airbyte/actions/runs/1827045073

lmossman · 2022-02-11T01:12:41Z

/publish connector=connectors/destination-databricks

🕑 connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/1827045494
✅ connectors/destination-databricks https://github.com/airbytehq/airbyte/actions/runs/1827045494

lmossman · 2022-02-11T01:12:52Z

/publish connector=connectors/destination-dev-null

🕑 connectors/destination-dev-null https://github.com/airbytehq/airbyte/actions/runs/1827045993
✅ connectors/destination-dev-null https://github.com/airbytehq/airbyte/actions/runs/1827045993

lmossman · 2022-02-11T01:12:59Z

/publish connector=connectors/destination-dynamodb

🕑 connectors/destination-dynamodb https://github.com/airbytehq/airbyte/actions/runs/1827046516
✅ connectors/destination-dynamodb https://github.com/airbytehq/airbyte/actions/runs/1827046516

lmossman · 2022-02-11T01:13:08Z

/publish connector=connectors/destination-elasticsearch

🕑 connectors/destination-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/1827046817
✅ connectors/destination-elasticsearch https://github.com/airbytehq/airbyte/actions/runs/1827046817

edgao · 2022-02-12T00:28:55Z

state of the world:

destination-postgres and postgres-strict-encrypt can't publish to 0.3.14 because it was already published as part of Prevent SSH tunnel closing with idle timeout #9644; commented there to see if it can be merged to master. Then we would pull master into this branch + publish 0.3.15 from here.
other errors are described in https://docs.google.com/spreadsheets/d/1mUknSzp_kUcJ8-aEDpEVxfFoxKzcvLj-6kx1MH1foNI/edit#gid=0

tuliren · 2022-02-13T00:10:24Z

@lmossman, by the way, we no longer need to update the version in those json definition files (e.g. airbyte-config/init/src/main/resources/config/STANDARD_SOURCE_DEFINITION/435bb9a5-7887-4809-aa58-28c27df0d7ad.json). Those files still exist for backward compatibility. They are not used by the current Airbyte server any more. I will revert those changes to make the PR slightly simpler.

tuliren · 2022-02-13T03:46:54Z

In the future, it is probably better to merge in the changes first, and publish the connectors in separate PRs. Having one PR to update so many connectors is very messy. For example, none of the changelog is updated in the connector documentation. Also some of the connectors have been published with this PR, but the change is not merged, which can block other PRs trying to update the same connectors.

…o-java-connectors

tuliren · 2022-02-13T03:53:54Z

/publish connector=connectors/destination-gcs

🕑 connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1835719832
✅ connectors/destination-gcs https://github.com/airbytehq/airbyte/actions/runs/1835719832

…o-java-connectors

cgardens · 2022-02-18T05:27:22Z

wahoo! thanks for pushing it across the finish line.

cgardens · 2022-02-18T05:27:55Z

In the future, it is probably better to merge in the changes first, and publish the connectors in separate PRs. Having one PR to update so many connectors is very messy. For example, none of the changelog is updated in the connector documentation. Also some of the connectors have been published with this PR, but the change is not merged, which can block other PRs trying to update the same connectors.

+1 . agreed with liren.

lmossman added 2 commits February 10, 2022 15:56

add -XX:+ExitOnOutOfMemoryError JVM flag and bump versions of java co…

129207b

…nnectors

add jvm flags to java connectors that were missing them

25f327a

github-actions bot added area/connectors Connector related issues area/platform issues related to the platform area/scheduler area/server area/worker Related to worker labels Feb 11, 2022

lmossman temporarily deployed to more-secrets February 11, 2022 00:19 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 11, 2022 00:25 Inactive

lmossman requested a review from edgao February 11, 2022 00:26

octavia-squidington-iii temporarily deployed to more-secrets February 11, 2022 00:26 Inactive

edgao approved these changes Feb 11, 2022

View reviewed changes

cgardens approved these changes Feb 11, 2022

View reviewed changes

octavia-squidington-iii temporarily deployed to more-secrets February 11, 2022 00:45 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 11, 2022 20:44 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 11, 2022 20:45 Inactive

tuliren mentioned this pull request Feb 13, 2022

🎉 Destination GCS: fix connection check #10299

Merged

16 tasks

Ignore json connector definition files

1168838

tuliren temporarily deployed to more-secrets February 13, 2022 03:41 Inactive

Revert more json connector definition changes

43548bd

tuliren temporarily deployed to more-secrets February 13, 2022 03:45 Inactive

tuliren added 2 commits February 12, 2022 19:51

Merge branch 'master' into lmossman/add-exit-on-out-of-memory-error-t…

e16361d

…o-java-connectors

Bump gcs version

51e4b93

tuliren temporarily deployed to more-secrets February 13, 2022 03:57 Inactive

github-actions bot added the area/documentation Improvements or additions to documentation label Feb 13, 2022

tuliren temporarily deployed to more-secrets February 13, 2022 03:58 Inactive

octavia-squidington-iii temporarily deployed to more-secrets February 13, 2022 04:00 Inactive

edgao added 2 commits February 14, 2022 15:48

changelogs

4bbdefc

Merge branch 'master' into lmossman/add-exit-on-out-of-memory-error-t…

25f5ef1

…o-java-connectors

edgao merged commit 3d8a0dc into master Feb 14, 2022

edgao deleted the lmossman/add-exit-on-out-of-memory-error-to-java-connectors branch February 14, 2022 23:49

edgao temporarily deployed to more-secrets February 14, 2022 23:50 Inactive

edgao mentioned this pull request Feb 15, 2022

fix connector catalog #10331

Merged

tuliren mentioned this pull request Feb 15, 2022

Fix connector build #10335

Merged

noahkawasaki-airbyte mentioned this pull request Apr 20, 2022

Separate connectors /publish workflow into a build candidate and promotion to production GitOps pipeline pattern #12108

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ExitOnOutOfMemoryError to java connectors and bump versions #10256

Add ExitOnOutOfMemoryError to java connectors and bump versions #10256

lmossman commented Feb 11, 2022

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

edgao left a comment

cgardens left a comment

lmossman commented Feb 11, 2022

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

edgao commented Feb 12, 2022

tuliren commented Feb 13, 2022 •

edited

Loading

tuliren commented Feb 13, 2022 •

edited

Loading

tuliren commented Feb 13, 2022 •

edited by github-actions bot

Loading

cgardens commented Feb 18, 2022

cgardens commented Feb 18, 2022

Add ExitOnOutOfMemoryError to java connectors and bump versions #10256

Add ExitOnOutOfMemoryError to java connectors and bump versions #10256

Conversation

lmossman commented Feb 11, 2022

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

edgao left a comment

Choose a reason for hiding this comment

cgardens left a comment

Choose a reason for hiding this comment

lmossman commented Feb 11, 2022

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

lmossman commented Feb 11, 2022 • edited by github-actions bot Loading

edgao commented Feb 12, 2022

tuliren commented Feb 13, 2022 • edited Loading

tuliren commented Feb 13, 2022 • edited Loading

tuliren commented Feb 13, 2022 • edited by github-actions bot Loading

cgardens commented Feb 18, 2022

cgardens commented Feb 18, 2022

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

lmossman commented Feb 11, 2022 •

edited by github-actions bot

Loading

tuliren commented Feb 13, 2022 •

edited

Loading

tuliren commented Feb 13, 2022 •

edited

Loading

tuliren commented Feb 13, 2022 •

edited by github-actions bot

Loading