Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Chargebee: added coupon #10269

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Source Chargebee: added coupon #10269

merged 3 commits into from
Feb 15, 2022

Conversation

aadityasinha-dotcom
Copy link
Contributor

What

This PR adds Coupons model to the Chargebee connector.
Resolves #9702

Pre-merge Checklist

  • Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Feb 11, 2022
@aadityasinha-dotcom
Copy link
Contributor Author

@marcosmarxm can you review this PR?

marcosmarxm
marcosmarxm approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small fix I made in #10329

airbyte-integrations/connectors/source-chargebee/source_chargebee/streams.py Outdated Show resolved Hide resolved
@marcosmarxm
Copy link
Member

It's possible to give me access to your fork to push some changes?

@aadityasinha-dotcom
Copy link
Contributor Author

It's possible to give me access to your fork to push some changes?

Can I do that?

@aadityasinha-dotcom @marcosmarxm
Update airbyte-integrations/connectors/source-chargebee/source_charge…
ee5b474 
…bee/streams.py

Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
@marcosmarxm marcosmarxm merged commit 1c89320 into airbytehq:master Feb 15, 2022
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm marcosmarxm approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Source Chargebee: add new streams coupon, event and transaction
3 participants
@aadityasinha-dotcom @marcosmarxm @octavia-squidington-iii