Fix parsing of DBRef MongoDB objects #10276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
area/documentation
| | 0.1.1 | 2021-09-21 | [6364](https://github.com/airbytehq/airbyte/pull/6364) | Source MongoDb: added support via TLS/SSL | | ||
| | 0.1.0 | 2021-08-30 | [5530](https://github.com/airbytehq/airbyte/pull/5530) | New source: MongoDb ported to java | | ||
| |:--------| :--- | :--- | :--- | | ||
| | 0.1.11 | 2022-02-11 | [10276](https://github.com/airbytehq/airbyte/pull/10276) | Create a custom codec registry to handle DBRef MongoDB objects | |
There was a problem hiding this comment.
Suggested change
| | 0.1.11 | 2022-02-11 | [10276](https://github.com/airbytehq/airbyte/pull/10276) | Create a custom codec registry to handle DBRef MongoDB objects | | |
| | 0.1.12 | 2022-02-11 | [10276](https://github.com/airbytehq/airbyte/pull/10276) | Create a custom codec registry to handle DBRef MongoDB objects | |
Closed
alafanechere
approved these changes
Feb 21, 2022
|
Thanks @NahidOulmi for this contrib and glad it fixes your original problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Related to this issue : #9604
The default codec registry does not handle MongoDB DBRef objects.
This PR provides a fix to this issue.
How
The Mongo team provides a DBRefCodecProvider for handling DBRef objects.
This PR provides a custom codec registry that is derived from the default codec registry.
Only difference is the added DBRefCodecProvider in here.
Community member or Airbyter
./gradlew :airbyte-integrations:connectors:<name>:integrationTest.Integration & acceptation tests passed:
