Add persistence function for discovered schema #10326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
malikdiarra
force-pushed
the
persist-schema
branch
from
cbbceeb
to
669c9f4
Compare
malikdiarra
force-pushed
the
persist-schema
branch
from
669c9f4
to
7863845
Compare
tuliren
reviewed
Feb 15, 2022
...onfig/persistence/src/main/java/io/airbyte/config/persistence/DatabaseConfigPersistence.java
Outdated
Show resolved
Hide resolved
...onfig/persistence/src/main/java/io/airbyte/config/persistence/DatabaseConfigPersistence.java
Outdated
Show resolved
Hide resolved
.../io/airbyte/db/instance/configs/migrations/V0_35_28_001__AddActorCatalogMetadataColumns.java
Outdated
Show resolved
Hide resolved
.../io/airbyte/db/instance/configs/migrations/V0_35_28_001__AddActorCatalogMetadataColumns.java
Outdated
Show resolved
Hide resolved
…sistence/DatabaseConfigPersistence.java Co-authored-by: LiRen Tu <tuliren.git@outlook.com>
…sistence/DatabaseConfigPersistence.java Co-authored-by: LiRen Tu <tuliren.git@outlook.com>
…grations/V0_35_28_001__AddActorCatalogMetadataColumns.java Co-authored-by: LiRen Tu <tuliren.git@outlook.com>
…grations/V0_35_28_001__AddActorCatalogMetadataColumns.java Co-authored-by: LiRen Tu <tuliren.git@outlook.com>
This is done! |
subodh1810
requested changes
Feb 15, 2022
| .from(ACTOR_CATALOG_FETCH_EVENT) | ||
| .where(ACTOR_CATALOG_FETCH_EVENT.ID.eq(actorCatalogFetchEvent.getId()))); | ||
|
|
||
| if (!isExistingConfig) { |
There was a problem hiding this comment.
Shouldnt we have an update feature like other configs?
There was a problem hiding this comment.
Those table are used to cache information, so insert and get should really be the only access patterns. I can add the update case for consistency though
There was a problem hiding this comment.
I added the update case, as well as deletion as well as dumpAllConfig and replaceAllConfig operations.
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| public class V0_35_28_001__AddActorCatalogMetadataColumns extends BaseJavaMigration { |
There was a problem hiding this comment.
Can we add a test for the migration?
malikdiarra
force-pushed
the
persist-schema
branch
from
83a2af4
to
7e2b69c
Compare
Both ActorCatalog and ActorCatalogFetchEvent are now updated during a writeConfig operation if their UUID is already present in DB.
- delete - replaceAllConfigs - dumpConfigs
malikdiarra
force-pushed
the
persist-schema
branch
from
d88fd4e
to
eb0a589
Compare
subodh1810
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This adds persistence functions for the schema tables added in #10286
This PR is part of #9895