Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Google Ads: add network fields to click view stream #10372

Merged
merged 7 commits into from
Feb 25, 2022

Conversation

vitaliizazmic
Copy link
Contributor

@vitaliizazmic vitaliizazmic commented Feb 16, 2022

What

Added network fields to Click View stream:

  • segments.ad_network_type
  • campaign.network_settings.target_content_network
  • campaign.network_settings.target_google_search
  • campaign.network_settings.target_partner_search_network
  • campaign.network_settings.target_search_network

Closes #8331

How

Added new fields to click_view schema

  • Community member? Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • docs/SUMMARY.md
    • docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
    • docs/integrations/README.md
    • airbyte-integrations/builds.md
  • PR name follows PR naming conventions

@vitaliizazmic vitaliizazmic added this to the Connectors Feb 25 milestone Feb 16, 2022
@vitaliizazmic vitaliizazmic self-assigned this Feb 16, 2022
@github-actions github-actions bot added the area/connectors Connector related issues label Feb 16, 2022
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@db8053f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2bc34a6 differs from pull request most recent head a2eb5b6. Consider uploading reports for the commit a2eb5b6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10372   +/-   ##
=========================================
  Coverage          ?   70.05%           
=========================================
  Files             ?        5           
  Lines             ?      344           
  Branches          ?        0           
=========================================
  Hits              ?      241           
  Misses            ?      103           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db8053f...a2eb5b6. Read the comment docs.

@keu
Copy link
Contributor

keu commented Feb 16, 2022

you forgot to add segments.ad_network_type to PK of click_view stream

@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 23, 2022 07:46 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 23, 2022 07:46 Inactive
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Feb 23, 2022

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1886053152
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1886053152
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               68     10    85%
source_google_ads/streams.py                 130     25    81%
source_google_ads/source.py                   73     24    67%
source_google_ads/custom_query_stream.py      75     50    33%
--------------------------------------------------------------
TOTAL                                        348    109    69%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/__init__.py                  2      0   100%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/streams.py                 130     11    92%
source_google_ads/google_ads.py               68      7    90%
source_google_ads/source.py                   73     19    74%
--------------------------------------------------------------
TOTAL                                        348     43    88%

Python short test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.7/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 21 passed, 1 skipped in 1422.66s (0:23:42) ==================

@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 23, 2022 07:59 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 23, 2022 07:59 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 23, 2022 08:01 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 23, 2022 22:21 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 23, 2022 22:21 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 25, 2022 05:35 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 25, 2022 05:35 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Feb 25, 2022
@vitaliizazmic
Copy link
Contributor Author

vitaliizazmic commented Feb 25, 2022

/publish connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1897079121
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/1897079121

@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 25, 2022 05:49 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 25, 2022 05:49 Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 25, 2022 05:50 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 25, 2022 06:40 Inactive
@vitaliizazmic vitaliizazmic temporarily deployed to more-secrets February 25, 2022 06:40 Inactive
@vitaliizazmic vitaliizazmic merged commit 3a5beb7 into master Feb 25, 2022
@vitaliizazmic vitaliizazmic deleted the vitalii/8331_google_ads_add_network_fields branch February 25, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Google Ads: Add network fields to Click View stream
5 participants