Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicit set final variables in BootloaderApp #10422

Merged
merged 1 commit into from Feb 17, 2022
Merged

Explicit set final variables in BootloaderApp #10422

merged 1 commit into from Feb 17, 2022

Conversation

malikdiarra
Copy link
Contributor

What

Make sure final variable are correctly set as such in BootloaderApp class. This will remove a bit of noise in #10387

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@benmoriceau
Copy link
Contributor

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Is it your first PR, it is strange that you are seeing this.

@malikdiarra
Copy link
Contributor Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Is it your first PR, it is strange that you are seeing this.

Not my first PR but I never signed that stuff. I just did it now. Thanks!

@malikdiarra malikdiarra merged commit 1ce230d into master Feb 17, 2022
@malikdiarra malikdiarra deleted the malik/fix-final-bootloaderapp branch February 17, 2022 21:52
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmoriceau benmoriceau benmoriceau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@malikdiarra @CLAassistant @benmoriceau