Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Hubspot: add "format": "date-time" #10492

Merged
merged 7 commits into from
Feb 22, 2022

Conversation

augan-rymkhan
Copy link
Contributor

@augan-rymkhan augan-rymkhan commented Feb 21, 2022

What

Resolves #5688

How

Set format as date-time in all stream fields, where its format is datetime.

Recommended reading order

any order

@github-actions github-actions bot added the area/connectors Connector related issues label Feb 21, 2022
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets February 21, 2022 09:29 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets February 21, 2022 09:29 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets February 21, 2022 10:41 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets February 21, 2022 10:41 Inactive
@augan-rymkhan augan-rymkhan marked this pull request as ready for review February 21, 2022 13:10
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets February 21, 2022 15:15 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets February 21, 2022 15:15 Inactive
@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@5464b1c). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2a2e95b differs from pull request most recent head 9ec4ad1. Consider uploading reports for the commit 9ec4ad1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10492   +/-   ##
=========================================
  Coverage          ?   81.12%           
=========================================
  Files             ?        4           
  Lines             ?      726           
  Branches          ?        0           
=========================================
  Hits              ?      589           
  Misses            ?      137           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5464b1c...9ec4ad1. Read the comment docs.

@augan-rymkhan
Copy link
Contributor Author

augan-rymkhan commented Feb 21, 2022

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1877185978
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1877185978
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_hubspot/errors.py         6      0   100%
source_hubspot/__init__.py       2      0   100%
source_hubspot/source.py        12      1    92%
source_hubspot/api.py          555    132    76%
source_hubspot/client.py        40     12    70%
------------------------------------------------
TOTAL                          615    145    76%

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 21, 2022 16:09 Inactive
@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Feb 22, 2022
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets February 22, 2022 12:50 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets February 22, 2022 12:50 Inactive
@augan-rymkhan
Copy link
Contributor Author

augan-rymkhan commented Feb 22, 2022

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1881639267
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1881639267

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 22, 2022 12:53 Inactive
@augan-rymkhan
Copy link
Contributor Author

augan-rymkhan commented Feb 22, 2022

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1882048615
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1882048615
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  70     17    76%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              275    106    61%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  876    259    70%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_hubspot/errors.py         6      0   100%
source_hubspot/__init__.py       2      0   100%
source_hubspot/streams.py      655    121    82%
source_hubspot/source.py        69     16    77%
------------------------------------------------
TOTAL                          732    137    81%

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 22, 2022 14:16 Inactive
@augan-rymkhan
Copy link
Contributor Author

augan-rymkhan commented Feb 22, 2022

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1882122779
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/1882122779

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets February 22, 2022 14:30 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets February 22, 2022 14:45 Inactive
@augan-rymkhan augan-rymkhan temporarily deployed to more-secrets February 22, 2022 14:45 Inactive
@augan-rymkhan augan-rymkhan merged commit 9c9dfb2 into master Feb 22, 2022
@augan-rymkhan augan-rymkhan deleted the arymkhan/source-hubspot-add-date-time-format branch February 22, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source Hubspot: add date-type to fields in all schemas
4 participants