-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Destination Clickhouse: enable normalization for Secure connections #10754
Destination Clickhouse: enable normalization for Secure connections #10754
Conversation
thanks for the contribution @kzzzr is it possible to you sign the CLA? The team will review your contribution during this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM only I want to test if the dbt container read correctly the value.
@@ -279,6 +279,7 @@ def transform_clickhouse(config: Dict[str, Any]): | |||
"port": config["port"], | |||
"schema": config["database"], | |||
"user": config["username"], | |||
"secure": config["ssl"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern here is if the config file created by the UI read as boolean and not as a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, it is boolean:
airbyte/airbyte-integrations/connectors/destination-clickhouse/src/main/resources/spec.json
Lines 59 to 65 in a4e8417
"ssl": { | |
"title": "SSL Connection", | |
"description": "Encrypt data using SSL.", | |
"type": "boolean", | |
"default": false, | |
"order": 6 | |
} |
I've managed to run normalization successfully, only I had to change NORMALIZATION_VERSION = "dev"
, build SUB_BUILD=PLATFORM ./gradlew build
and test it with UI locally.
Line 17 in a4e8417
public static final String NORMALIZATION_VERSION = "0.1.68"; |
…github.com:kzzzr/airbyte into marcos/test-pr-10754
having some problems publishing the new version of normalization. |
What
Enable normalization for Destination Clickhouse with SSL connection by configuring
Secure
parameter inprofiles.yml
#9837
How
By supplying key
"secure": config["ssl"]
to methodtransform_clickhouse
Recommended reading order
transform.py
test_transform_config.py
🚨 User Impact 🚨
No breaking changes
Pre-merge Checklist
Expand the relevant checklist and delete the others.
Updating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereTests
Unit
TestTransformConfig.test_transform_clickhouse